squash 'resources/unpacked/devtools' changes from 3284500..5374413

5374413 [DevTools] Fix bad unicode symbols in network conditions.
217ba4a DevTools: [SourceMapNamesResolver] do not throw exception on hovering over compiled
8380dd1 DevTools: [Console] fix console stick-to-bottom behavior in case of multiline messages
41ef867 [DevTools] Move inspect from Inspector to Runtime.
ec6ab05 DevTools: display recent SW revisions on top of the list, remove stale redundant ones.
cd037cf DevTools Timeline: show input latencies and animations under RAIL group
fb2d391 SameSite: Teach devtools about the new 'samesite' syntax.
22444a0 DevTools: Fix first paint screenshot.
baf10e5 [DevTools] Add "Show all" check box in Service Worker view.
e07ca99 DevTools: [Elements] set non-zero hide timeout timer for image popover
bcf91f0 DevTools: Refactor CPU profile tree
c2b629e [DevTools] Use plain text for network conditions menu.
0f18ee4 DevTools: remove the step into async experiment, it'll need to be implemented differently.
66fc008 DevTools: trim file paths at the middle in source selection dialog
6b5f3d8 DevTools: remove unused "Auto-reload generated CSS" setting
3b8792c DevTools: [SASS] speedup AST.findNodeForPosition method
47ff8c4 [DevTools] Fix stale requests in Network panel not being refreshed
9089491 DevTools: move the force update SW on reload checkbox to the Resources / Service Workers view. Remove the "Debug on start" option from Resources / Service Workers.

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: 5374413

Author: darwin

devtools.gypi

@@ -638,7 +638,6 @@
             'front_end/sources/uiList.css',
             'front_end/sources/AddSourceMapURLDialog.js',
             'front_end/sources/AdvancedSearchView.js',
-            'front_end/sources/AsyncOperationsSidebarPane.js',
             'front_end/sources/CallStackSidebarPane.js',
             'front_end/sources/CSSSourceFrame.js',
             'front_end/sources/EditingLocationHistoryManager.js',
@@ -658,7 +657,6 @@
             'front_end/sources/ScopeChainSidebarPane.js',
             'front_end/sources/ScriptFormatter.js',
             'front_end/sources/ScriptFormatterEditorAction.js',
-            'front_end/sources/ServiceWorkersSidebarPane.js',
             'front_end/sources/SimpleHistoryManager.js',
             'front_end/sources/SourceMapNamesResolver.js',
             'front_end/sources/SourcesNavigator.js',

front_end/common/TextRange.js

@@ -186,6 +186,20 @@ WebInspector.TextRange.prototype = {
         return 0;
     },
 
+    /**
+     * @param {number} lineNumber
+     * @param {number} columnNumber
+     * @return {number}
+     */
+    compareToPosition: function(lineNumber, columnNumber)
+    {
+        if (lineNumber < this.startLine || (lineNumber === this.startLine && columnNumber < this.startColumn))
+            return -1;
+        if (lineNumber > this.endLine || (lineNumber === this.endLine && columnNumber > this.endColumn))
+            return 1;
+        return 0;
+    },
+
     /**
      * @param {!WebInspector.TextRange} other
      * @return {boolean}

front_end/components/NetworkConditionsSelector.js

@@ -23,18 +23,20 @@ WebInspector.NetworkConditionsGroup;
 
 /**
  * @param {number} throughput
+ * @param {boolean=} plainText
  * @return {string}
  */
-WebInspector.NetworkConditionsSelector._throughputText = function(throughput)
+WebInspector.NetworkConditionsSelector._throughputText = function(throughput, plainText)
 {
     if (throughput < 0)
         return "";
     var throughputInKbps = throughput / (1024 / 8);
+    var delimiter = plainText ? "" : " ";
     if (throughputInKbps < 1024)
-        return WebInspector.UIString("%d kb/s", throughputInKbps);
+        return WebInspector.UIString("%d%skb/s", throughputInKbps, delimiter);
     if (throughputInKbps < 1024 * 10)
-        return WebInspector.UIString("%.1f Mb/s", throughputInKbps / 1024);
-    return WebInspector.UIString("%d Mb/s", (throughputInKbps / 1024) | 0);
+        return WebInspector.UIString("%.1f%sMb/s", throughputInKbps / 1024, delimiter);
+    return WebInspector.UIString("%d%sMb/s", (throughputInKbps / 1024) | 0, delimiter);
 }
 
 /** @type {!Array.<!WebInspector.NetworkManager.Conditions>} */
@@ -52,9 +54,10 @@ WebInspector.NetworkConditionsSelector._presets = [
 
 /**
  * @param {!WebInspector.NetworkManager.Conditions} conditions
+ * @param {boolean=} plainText
  * @return {!{text: string, title: string}}
  */
-WebInspector.NetworkConditionsSelector._conditionsTitle = function(conditions)
+WebInspector.NetworkConditionsSelector._conditionsTitle = function(conditions, plainText)
 {
     var downloadInKbps = conditions.download / (1024 / 8);
     var uploadInKbps = conditions.upload / (1024 / 8);
@@ -63,9 +66,10 @@ WebInspector.NetworkConditionsSelector._conditionsTitle = function(conditions)
     if (!isThrottling)
         return {text: conditionTitle, title: conditionTitle};
 
-    var downloadText = WebInspector.NetworkConditionsSelector._throughputText(conditions.download);
-    var uploadText = WebInspector.NetworkConditionsSelector._throughputText(conditions.upload);
-    var title = WebInspector.UIString("%s (%s\u2b07 %s\u2b06 %dms RTT)", conditionTitle, downloadText, uploadText, conditions.latency);
+    var downloadText = WebInspector.NetworkConditionsSelector._throughputText(conditions.download, plainText);
+    var uploadText = WebInspector.NetworkConditionsSelector._throughputText(conditions.upload, plainText);
+    var pattern = plainText ? "%s (%dms, %s, %s)" : "%s (%dms RTT, %s\u2b07, %s\u2b06)";
+    var title = WebInspector.UIString(pattern, conditionTitle, conditions.latency, downloadText, uploadText);
     return {text: title, title: WebInspector.UIString("Maximum download throughput: %s.\r\nMaximum upload throughput: %s.\r\nMinimum round-trip time: %dms.", downloadText, uploadText, conditions.latency)};
 }
 
@@ -143,7 +147,7 @@ WebInspector.NetworkConditionsSelector.decorateSelect = function(selectElement)
                 options.push(null);
             }
             for (var conditions of group.items) {
-                var title = WebInspector.NetworkConditionsSelector._conditionsTitle(conditions);
+                var title = WebInspector.NetworkConditionsSelector._conditionsTitle(conditions, true);
                 var option = new Option(title.text, title.text);
                 option.title = title.title;
                 groupElement.appendChild(option);
@@ -196,7 +200,7 @@ WebInspector.NetworkConditionsSelector.createToolbarMenuButton = function()
             if (!conditions)
                 contextMenu.appendSeparator();
             else
-                contextMenu.appendCheckboxItem(WebInspector.NetworkConditionsSelector._conditionsTitle(conditions).text, selector.optionSelected.bind(selector, conditions), selectedIndex === index);
+                contextMenu.appendCheckboxItem(WebInspector.NetworkConditionsSelector._conditionsTitle(conditions, true).text, selector.optionSelected.bind(selector, conditions), selectedIndex === index);
         }
         contextMenu.appendItem(WebInspector.UIString("Edit\u2026"), selector.revealAndUpdate.bind(selector));
     }

front_end/components/ShortcutsScreen.js

@@ -249,8 +249,6 @@ WebInspector.ShortcutsScreen.registerShortcuts = function()
     section.addAlternateKeys(WebInspector.shortcutRegistry.shortcutDescriptorsForAction("debugger.step-over"), WebInspector.UIString("Step over"));
     section.addAlternateKeys(WebInspector.shortcutRegistry.shortcutDescriptorsForAction("debugger.step-into"), WebInspector.UIString("Step into"));
     section.addAlternateKeys(WebInspector.shortcutRegistry.shortcutDescriptorsForAction("debugger.step-out"), WebInspector.UIString("Step out"));
-    if (Runtime.experiments.isEnabled("stepIntoAsync"))
-        section.addAlternateKeys(WebInspector.shortcutRegistry.shortcutDescriptorsForAction("debugger.step-into"), WebInspector.UIString("Step into"));
 
     var nextAndPrevFrameKeys = WebInspector.ShortcutsScreen.SourcesPanelShortcuts.NextCallFrame.concat(WebInspector.ShortcutsScreen.SourcesPanelShortcuts.PrevCallFrame);
     section.addRelatedKeys(nextAndPrevFrameKeys, WebInspector.UIString("Next/previous call frame"));

front_end/components_lazy/CookiesTable.js

@@ -51,7 +51,7 @@ WebInspector.CookiesTable = function(expandable, refreshCallback, selectedCallba
         {id: "size", title: WebInspector.UIString("Size"), sortable: true, align: WebInspector.DataGrid.Align.Right, weight: 7},
         {id: "httpOnly", title: WebInspector.UIString("HTTP"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7},
         {id: "secure", title: WebInspector.UIString("Secure"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7},
-        {id: "sameSite", title: WebInspector.UIString("Same-Site"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7}
+        {id: "sameSite", title: WebInspector.UIString("SameSite"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7}
     ];
 
     if (readOnly)
@@ -261,7 +261,7 @@ WebInspector.CookiesTable.prototype = {
         const checkmark = "\u2713";
         data.httpOnly = (cookie.httpOnly() ? checkmark : "");
         data.secure = (cookie.secure() ? checkmark : "");
-        data.sameSite = (cookie.sameSite() ? checkmark : "");
+        data.sameSite = cookie.sameSite() || "";
 
         var node = new WebInspector.DataGridNode(data);
         node.cookie = cookie;

front_end/components_lazy/FilmStripModel.js

@@ -71,17 +71,8 @@ WebInspector.FilmStripModel.prototype = {
      */
     frameByTimestamp: function(timestamp)
     {
-        /**
-         * @param {number} timestamp
-         * @param {!WebInspector.FilmStripModel.Frame} frame
-         * @return {number}
-         */
-        function comparator(timestamp, frame)
-        {
-            return timestamp - frame.timestamp;
-        }
-        var index = this._frames.lowerBound(timestamp, comparator);
-        return index < this._frames.length ? this._frames[index] : null;
+        var index = this._frames.upperBound(timestamp, (timestamp, frame) => timestamp - frame.timestamp) - 1;
+        return index >= 0 ? this._frames[index] : null;
     }
 }
 

front_end/elements/ElementsTreeOutline.js

@@ -73,7 +73,7 @@ WebInspector.ElementsTreeOutline = function(domModel, omitRootDOMNode, selectEna
     this._visible = false;
 
     this._popoverHelper = new WebInspector.PopoverHelper(this._element, this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
-    this._popoverHelper.setTimeout(0);
+    this._popoverHelper.setTimeout(0, 100);
 
     /** @type {!Map<!WebInspector.DOMNode, !WebInspector.ElementsTreeOutline.UpdateRecord>} */
     this._updateRecords = new Map();

front_end/main/Main.js

@@ -122,7 +122,6 @@ WebInspector.Main.prototype = {
         Runtime.experiments.register("timelineShowAllEvents", "Show all events on Timeline", true);
         Runtime.experiments.register("timelineLatencyInfo", "Show input latency events on the Timeline", true);
         Runtime.experiments.register("securityPanel", "Security panel");
-        Runtime.experiments.register("stepIntoAsync", "Step into async");
         Runtime.experiments.register("timelineFlowEvents", "Timeline flow events", true);
         Runtime.experiments.register("timelineInvalidationTracking", "Timeline invalidation tracking", true);
         Runtime.experiments.register("timelineRecordingPerspectives", "Timeline recording perspectives UI");
@@ -543,42 +542,6 @@ WebInspector.Main.prototype = {
         WebInspector.Main._reloadPage(hard);
     },
 
-    /**
-     * @override
-     * @param {!RuntimeAgent.RemoteObject} payload
-     * @param {!Object=} hints
-     */
-    inspect: function(payload, hints)
-    {
-        var object = this._mainTarget.runtimeModel.createRemoteObject(payload);
-        if (object.isNode()) {
-            WebInspector.Revealer.revealPromise(object).then(object.release.bind(object));
-            return;
-        }
-
-        if (object.type === "function") {
-            WebInspector.RemoteFunction.objectAsFunction(object).targetFunctionDetails().then(didGetDetails);
-            return;
-        }
-
-        /**
-         * @param {?WebInspector.DebuggerModel.FunctionDetails} response
-         */
-        function didGetDetails(response)
-        {
-            object.release();
-
-            if (!response || !response.location)
-                return;
-
-            WebInspector.Revealer.reveal(WebInspector.debuggerWorkspaceBinding.rawLocationToUILocation(response.location));
-        }
-
-        if (hints.copyToClipboard)
-            InspectorFrontendHost.copyText(object.value);
-        object.release();
-    },
-
     /**
      * @override
      * @param {string} reason

front_end/network/NetworkLogView.js

@@ -961,7 +961,10 @@ WebInspector.NetworkLogView.prototype = {
 
         var dataGrid = this._dataGrid;
         var rootNode = dataGrid.rootNode();
+        /** @type {!Array<!WebInspector.NetworkDataGridNode> } */
         var nodesToInsert = [];
+        /** @type {!Array<!WebInspector.NetworkDataGridNode> } */
+        var nodesToRefresh = [];
         for (var requestId in this._staleRequestIds) {
             var node = this._nodesByRequestId.get(requestId);
             if (!node)
@@ -976,6 +979,8 @@ WebInspector.NetworkLogView.prototype = {
                 if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol])
                     nodesToInsert.push(node);
             }
+            if (!isFilteredOut)
+                nodesToRefresh.push(node);
             var request = node.request();
             this._timeCalculator.updateBoundaries(request);
             this._durationCalculator.updateBoundaries(request);
@@ -985,10 +990,12 @@ WebInspector.NetworkLogView.prototype = {
             var node = nodesToInsert[i];
             var request = node.request();
             dataGrid.insertChild(node);
-            node.refresh();
             node[WebInspector.NetworkLogView._isMatchingSearchQuerySymbol] = this._matchRequest(request);
         }
 
+        for (var node of nodesToRefresh)
+            node.refresh();
+
         this._highlightNthMatchedRequestForSearch(this._updateMatchCountAndFindMatchIndex(this._currentMatchedRequestNode), false);
 
         if (!this.calculator().boundary().equals(oldBoundary)) {

front_end/profiler/CPUProfileBottomUpDataGrid.js

@@ -178,12 +178,14 @@ WebInspector.BottomUpProfileDataGridNode._sharedPopulate = function(container)
 /**
  * @constructor
  * @extends {WebInspector.ProfileDataGridTree}
- * @param {!WebInspector.CPUProfileView} profileView
+ * @param {!WebInspector.ProfileDataGridNode.Formatter} formatter
+ * @param {!WebInspector.SearchableView} searchableView
  * @param {!ProfilerAgent.CPUProfileNode} rootProfileNode
+ * @param {number} totalTime
  */
-WebInspector.BottomUpProfileDataGridTree = function(profileView, rootProfileNode)
+WebInspector.BottomUpProfileDataGridTree = function(formatter, searchableView, rootProfileNode, totalTime)
 {
-    WebInspector.ProfileDataGridTree.call(this, profileView, rootProfileNode);
+    WebInspector.ProfileDataGridTree.call(this, formatter, searchableView, totalTime);
 
     // Iterate each node in pre-order.
     var profileNodeUIDs = 0;
@@ -304,22 +306,22 @@ WebInspector.BottomUpProfileDataGridTree.prototype = {
      * @param {!WebInspector.SearchableView.SearchConfig} searchConfig
      * @param {boolean} shouldJump
      * @param {boolean=} jumpBackwards
-     * @return {number}
      */
     performSearch: function(searchConfig, shouldJump, jumpBackwards)
     {
         this.searchCanceled();
         var matchesQuery = this._matchFunction(searchConfig);
         if (!matchesQuery)
-            return 0;
+            return;
 
         this._searchResults = [];
         for (var current = this.children[0]; current; current = current.traverseNextNode(true, null, true)) {
             if (matchesQuery(current))
                 this._searchResults.push({ profileNode: current });
         }
         this._searchResultIndex = jumpBackwards ? 0 : this._searchResults.length - 1;
-        return this._searchResults.length;
+        this._searchableView.updateSearchMatchesCount(this._searchResults.length);
+        this._searchableView.updateCurrentMatchIndex(this._searchResultIndex);
     },
 
     /**