squash 'resources/unpacked/devtools' changes from 584b79d..e841464

e841464 Update DevTools DEPS.
e14c2ba Update DevTools Chromium DEPS.
412c7c0 Update DevTools DEPS.
7fbd457 Update DevTools DEPS.
d186adc Add telemetry for keyboard shortcuts
6e53c0c Audits: Roll Lighthouse to front_end/third_party
ead1214 [utilities] Remove Array#select
24054e6 Enable no-else-return lint rule with autofix
395cc9a [e2e] Ensures console messages are populated
52f66b9 Fix copy-paste error on dir check
cfeaf15 Updates boot perf timing to be 2 decimal places
60d3017 [e2e] Migrate http/tests/devtools/search/sources-search-scope.js to e2e
aff4ec7 Update DevTools DEPS.
732b47f Fix clicking on labels for checkboxes
722ed11 Ensure we import `errno` in ts_library.py
5922326 Remove `String.prototype.computeLineEndings`
39d01b8 Typecheck EventTarget.js
56e8c7a TypeScript CharacterIdMap_test into Ninja
c51e8b9 [perf] Updates boot perf test
6919027 Typecheck Common.UIString
8ea153c Reland "Typescriptify FormattedContentBuilder + move tests"
0ea6f7e Prepare BreakpointManager.js for asynchronous source mapping
0b5b87d Revert "Typescriptify FormattedContentBuilder + move tests"
d63d4ea Update DevTools DEPS.
dcafda8 Switch the Media tab to ES Modules
eecf850 Fix Grid accessibility name.
6455c39 Move Trie test to being built with Ninja
e2dc3fd Typescriptify FormattedContentBuilder + move tests
7e3f65f Remove transparent border-top from Elements tree rows
04a5635 Run TypeScript without building mode
0740564 Update screenshot testing to enable element screenshots
d03ab1d Add toolbar showing count of warnings to issues panel

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: e841464

Author: darwin

.eslintignore

@@ -8,8 +8,6 @@ front_end/.eslintrc.js
 front_end/InspectorBackendCommands.js
 front_end/SupportedCSSProperties.js
 front_end/accessibility/ARIAProperties.js
-front_end/lighthouse_worker/lighthouse/
-front_end/lighthouse/lighthouse/
 front_end/cm/
 front_end/cm_headless/
 front_end/cm_modes/

.eslintrc.js

@@ -43,28 +43,29 @@ module.exports = {
     'eol-last': 2,
 
     // anti-patterns
-    'no-with': 2,
-    'no-multi-str': 2,
     'no-caller': 2,
+    'no-cond-assign': 2,
+    'no-console': [2, {'allow': ['assert', 'context', 'error', 'timeStamp', 'time', 'timeEnd', 'warn']}],
+    'no-debugger': 2,
+    'no-dupe-keys': 2,
+    'no-duplicate-case': 2,
+    'no-else-return': [2, {'allowElseIf': false}],
+    'no-empty-character-class': 2,
     'no-implied-eval': 2,
     'no-labels': 2,
+    'no-multi-str': 2,
     'no-new-object': 2,
     'no-octal-escape': 2,
     'no-self-compare': 2,
     'no-shadow-restricted-names': 2,
-    'no-cond-assign': 2,
-    'no-debugger': 2,
-    'no-console': [2, {'allow': ['assert', 'context', 'error', 'timeStamp', 'time', 'timeEnd', 'warn']}],
-    'no-dupe-keys': 2,
-    'no-duplicate-case': 2,
-    'no-empty-character-class': 2,
     'no-unreachable': 2,
     'no-unsafe-negation': 2,
-    'radix': 2,
-    'valid-typeof': 2,
+    'no-unused-vars': [2, {'args': 'none', 'vars': 'local'}],
     'no-var': 2,
+    'no-with': 2,
     'prefer-const': 2,
-    'no-unused-vars': [2, {'args': 'none', 'vars': 'local'}],
+    'radix': 2,
+    'valid-typeof': 2,
 
     // es2015 features
     'require-yield': 2,

.gitignore

@@ -46,3 +46,6 @@ test/screenshots/**/*.js
 !test/screenshots/**/interactive.js
 test/screenshots/**/*.tsbuildinfo
 test/screenshots/.generated
+test/perf/.generated
+test/perf/**/*.js
+test/perf/**/*.tsbuildinfo

BUILD.gn

@@ -26,15 +26,10 @@ all_devtools_files = [
   "front_end/lighthouse_worker.js",
   "front_end/lighthouse_worker.json",
   "front_end/lighthouse_worker/LighthouseService.js",
-  "front_end/lighthouse_worker/lighthouse/lighthouse-dt-bundle.js",
   "front_end/lighthouse_worker/module.json",
   "front_end/lighthouse/lighthouseDialog.css",
   "front_end/lighthouse/lighthousePanel.css",
   "front_end/lighthouse/lighthouseStartView.css",
-  "front_end/lighthouse/lighthouse/report.css",
-  "front_end/lighthouse/lighthouse/report.js",
-  "front_end/lighthouse/lighthouse/template.html",
-  "front_end/lighthouse/lighthouse/templates.html",
   "front_end/lighthouse/module.json",
   "front_end/axe_core_test_runner/AxeCoreTestRunner.js",
   "front_end/axe_core_test_runner/module.json",
@@ -177,18 +172,11 @@ all_devtools_files = [
   "front_end/layers/module.json",
   "front_end/main/module.json",
   "front_end/media/chevronTabbedPanel.css",
-  "front_end/media/ChevronTabbedPanel.js",
   "front_end/media/eventDisplayTable.css",
-  "front_end/media/EventDisplayTable.js",
-  "front_end/media/MainView.js",
-  "front_end/media/MediaModel.js",
   "front_end/media/mediaView.css",
   "front_end/media/module.json",
-  "front_end/media/PlayerDetailView.js",
   "front_end/media/playerListView.css",
-  "front_end/media/PlayerListView.js",
   "front_end/media/playerPropertiesView.css",
-  "front_end/media/PlayerPropertiesView.js",
   "front_end/mobile_throttling/module.json",
   "front_end/mobile_throttling/throttlingSettingsTab.css",
   "front_end/ndb_app.json",
@@ -316,6 +304,12 @@ all_devtools_files = [
   "front_end/text_utils/module.json",
   "front_end/third_party/fabricjs/fabric.js",
   "front_end/third_party/fabricjs/module.json",
+  "front_end/third_party/lighthouse/lighthouse-dt-bundle.js",
+  "front_end/third_party/lighthouse/report-assets/report.css",
+  "front_end/third_party/lighthouse/report-assets/report.js",
+  "front_end/third_party/lighthouse/report-assets/report-generator.js",
+  "front_end/third_party/lighthouse/report-assets/template.html",
+  "front_end/third_party/lighthouse/report-assets/templates.html",
   "front_end/third_party/wasmparser/module.json",
   "front_end/timeline_model/module.json",
   "front_end/timeline/historyToolbarButton.css",
@@ -381,54 +375,54 @@ all_devtools_files = [
 ]
 
 lighthouse_locale_files = [
-  "front_end/lighthouse_worker/lighthouse/locales/ar-XB.json",
-  "front_end/lighthouse_worker/lighthouse/locales/ar.json",
-  "front_end/lighthouse_worker/lighthouse/locales/bg.json",
-  "front_end/lighthouse_worker/lighthouse/locales/ca.json",
-  "front_end/lighthouse_worker/lighthouse/locales/cs.json",
-  "front_end/lighthouse_worker/lighthouse/locales/da.json",
-  "front_end/lighthouse_worker/lighthouse/locales/de.json",
-  "front_end/lighthouse_worker/lighthouse/locales/el.json",
-  "front_end/lighthouse_worker/lighthouse/locales/en-GB.json",
-  "front_end/lighthouse_worker/lighthouse/locales/en-US.json",
-  "front_end/lighthouse_worker/lighthouse/locales/en-XA.json",
-  "front_end/lighthouse_worker/lighthouse/locales/en-XL.json",
-  "front_end/lighthouse_worker/lighthouse/locales/es-419.json",
-  "front_end/lighthouse_worker/lighthouse/locales/es.json",
-  "front_end/lighthouse_worker/lighthouse/locales/fi.json",
-  "front_end/lighthouse_worker/lighthouse/locales/fil.json",
-  "front_end/lighthouse_worker/lighthouse/locales/fr.json",
-  "front_end/lighthouse_worker/lighthouse/locales/he.json",
-  "front_end/lighthouse_worker/lighthouse/locales/hi.json",
-  "front_end/lighthouse_worker/lighthouse/locales/hr.json",
-  "front_end/lighthouse_worker/lighthouse/locales/hu.json",
-  "front_end/lighthouse_worker/lighthouse/locales/id.json",
-  "front_end/lighthouse_worker/lighthouse/locales/it.json",
-  "front_end/lighthouse_worker/lighthouse/locales/ja.json",
-  "front_end/lighthouse_worker/lighthouse/locales/ko.json",
-  "front_end/lighthouse_worker/lighthouse/locales/lt.json",
-  "front_end/lighthouse_worker/lighthouse/locales/lv.json",
-  "front_end/lighthouse_worker/lighthouse/locales/nl.json",
-  "front_end/lighthouse_worker/lighthouse/locales/no.json",
-  "front_end/lighthouse_worker/lighthouse/locales/pl.json",
-  "front_end/lighthouse_worker/lighthouse/locales/pt-PT.json",
-  "front_end/lighthouse_worker/lighthouse/locales/pt.json",
-  "front_end/lighthouse_worker/lighthouse/locales/ro.json",
-  "front_end/lighthouse_worker/lighthouse/locales/ru.json",
-  "front_end/lighthouse_worker/lighthouse/locales/sk.json",
-  "front_end/lighthouse_worker/lighthouse/locales/sl.json",
-  "front_end/lighthouse_worker/lighthouse/locales/sr-Latn.json",
-  "front_end/lighthouse_worker/lighthouse/locales/sr.json",
-  "front_end/lighthouse_worker/lighthouse/locales/sv.json",
-  "front_end/lighthouse_worker/lighthouse/locales/ta.json",
-  "front_end/lighthouse_worker/lighthouse/locales/te.json",
-  "front_end/lighthouse_worker/lighthouse/locales/th.json",
-  "front_end/lighthouse_worker/lighthouse/locales/tr.json",
-  "front_end/lighthouse_worker/lighthouse/locales/uk.json",
-  "front_end/lighthouse_worker/lighthouse/locales/vi.json",
-  "front_end/lighthouse_worker/lighthouse/locales/zh-HK.json",
-  "front_end/lighthouse_worker/lighthouse/locales/zh-TW.json",
-  "front_end/lighthouse_worker/lighthouse/locales/zh.json",
+  "front_end/third_party/lighthouse/locales/ar-XB.json",
+  "front_end/third_party/lighthouse/locales/ar.json",
+  "front_end/third_party/lighthouse/locales/bg.json",
+  "front_end/third_party/lighthouse/locales/ca.json",
+  "front_end/third_party/lighthouse/locales/cs.json",
+  "front_end/third_party/lighthouse/locales/da.json",
+  "front_end/third_party/lighthouse/locales/de.json",
+  "front_end/third_party/lighthouse/locales/el.json",
+  "front_end/third_party/lighthouse/locales/en-GB.json",
+  "front_end/third_party/lighthouse/locales/en-US.json",
+  "front_end/third_party/lighthouse/locales/en-XA.json",
+  "front_end/third_party/lighthouse/locales/en-XL.json",
+  "front_end/third_party/lighthouse/locales/es-419.json",
+  "front_end/third_party/lighthouse/locales/es.json",
+  "front_end/third_party/lighthouse/locales/fi.json",
+  "front_end/third_party/lighthouse/locales/fil.json",
+  "front_end/third_party/lighthouse/locales/fr.json",
+  "front_end/third_party/lighthouse/locales/he.json",
+  "front_end/third_party/lighthouse/locales/hi.json",
+  "front_end/third_party/lighthouse/locales/hr.json",
+  "front_end/third_party/lighthouse/locales/hu.json",
+  "front_end/third_party/lighthouse/locales/id.json",
+  "front_end/third_party/lighthouse/locales/it.json",
+  "front_end/third_party/lighthouse/locales/ja.json",
+  "front_end/third_party/lighthouse/locales/ko.json",
+  "front_end/third_party/lighthouse/locales/lt.json",
+  "front_end/third_party/lighthouse/locales/lv.json",
+  "front_end/third_party/lighthouse/locales/nl.json",
+  "front_end/third_party/lighthouse/locales/no.json",
+  "front_end/third_party/lighthouse/locales/pl.json",
+  "front_end/third_party/lighthouse/locales/pt-PT.json",
+  "front_end/third_party/lighthouse/locales/pt.json",
+  "front_end/third_party/lighthouse/locales/ro.json",
+  "front_end/third_party/lighthouse/locales/ru.json",
+  "front_end/third_party/lighthouse/locales/sk.json",
+  "front_end/third_party/lighthouse/locales/sl.json",
+  "front_end/third_party/lighthouse/locales/sr-Latn.json",
+  "front_end/third_party/lighthouse/locales/sr.json",
+  "front_end/third_party/lighthouse/locales/sv.json",
+  "front_end/third_party/lighthouse/locales/ta.json",
+  "front_end/third_party/lighthouse/locales/te.json",
+  "front_end/third_party/lighthouse/locales/th.json",
+  "front_end/third_party/lighthouse/locales/tr.json",
+  "front_end/third_party/lighthouse/locales/uk.json",
+  "front_end/third_party/lighthouse/locales/vi.json",
+  "front_end/third_party/lighthouse/locales/zh-HK.json",
+  "front_end/third_party/lighthouse/locales/zh-TW.json",
+  "front_end/third_party/lighthouse/locales/zh.json",
 ]
 
 all_devtools_files += lighthouse_locale_files
@@ -460,8 +454,8 @@ all_devtools_modules = [
   "front_end/lighthouse/LighthouseReportSelector.js",
   "front_end/lighthouse/LighthouseStartView.js",
   "front_end/lighthouse/LighthouseStatusView.js",
-  "front_end/lighthouse/lighthouse/report-generator.js",
-  "front_end/lighthouse/lighthouse/report.js",
+  "front_end/third_party/lighthouse/report-assets/report-generator.js",
+  "front_end/third_party/lighthouse/report-assets/report.js",
   "front_end/lighthouse/RadioSetting.js",
   "front_end/bindings/bindings.js",
   "front_end/bindings/bindings-legacy.js",
@@ -754,6 +748,15 @@ all_devtools_modules = [
   "front_end/main/main-legacy.js",
   "front_end/main/MainImpl.js",
   "front_end/main/SimpleApp.js",
+  "front_end/media/ChevronTabbedPanel.js",
+  "front_end/media/EventDisplayTable.js",
+  "front_end/media/MainView.js",
+  "front_end/media/media.js",
+  "front_end/media/media-legacy.js",
+  "front_end/media/MediaModel.js",
+  "front_end/media/PlayerDetailView.js",
+  "front_end/media/PlayerListView.js",
+  "front_end/media/PlayerPropertiesView.js",
   "front_end/mobile_throttling/mobile_throttling.js",
   "front_end/mobile_throttling/mobile_throttling-legacy.js",
   "front_end/mobile_throttling/MobileThrottlingSelector.js",
@@ -1387,8 +1390,8 @@ copied_devtools_modules = [
   "$resources_out_dir/lighthouse/LighthouseReportSelector.js",
   "$resources_out_dir/lighthouse/LighthouseStartView.js",
   "$resources_out_dir/lighthouse/LighthouseStatusView.js",
-  "$resources_out_dir/lighthouse/lighthouse/report-generator.js",
-  "$resources_out_dir/lighthouse/lighthouse/report.js",
+  "$resources_out_dir/third_party/lighthouse/report-assets/report-generator.js",
+  "$resources_out_dir/third_party/lighthouse/report-assets/report.js",
   "$resources_out_dir/lighthouse/RadioSetting.js",
   "$resources_out_dir/bindings/bindings.js",
   "$resources_out_dir/bindings/bindings-legacy.js",
@@ -1681,6 +1684,15 @@ copied_devtools_modules = [
   "$resources_out_dir/main/main-legacy.js",
   "$resources_out_dir/main/MainImpl.js",
   "$resources_out_dir/main/SimpleApp.js",
+  "$resources_out_dir/media/ChevronTabbedPanel.js",
+  "$resources_out_dir/media/EventDisplayTable.js",
+  "$resources_out_dir/media/MainView.js",
+  "$resources_out_dir/media/media.js",
+  "$resources_out_dir/media/media-legacy.js",
+  "$resources_out_dir/media/MediaModel.js",
+  "$resources_out_dir/media/PlayerDetailView.js",
+  "$resources_out_dir/media/PlayerListView.js",
+  "$resources_out_dir/media/PlayerPropertiesView.js",
   "$resources_out_dir/mobile_throttling/mobile_throttling.js",
   "$resources_out_dir/mobile_throttling/mobile_throttling-legacy.js",
   "$resources_out_dir/mobile_throttling/MobileThrottlingSelector.js",
@@ -2232,7 +2244,10 @@ group("devtools_all_files") {
   deps = [ ":devtools_frontend_resources_data" ]
 }
 
-devtools_typescript_deps = [ "front_end/common:common" ]
+devtools_typescript_deps = [
+  "front_end/common:common",
+  "front_end/formatter_worker",
+]
 
 devtools_frontend_resources_deps = devtools_typescript_deps + [
                                      ":aria_properties",
@@ -2265,6 +2280,7 @@ if (!is_android) {
   devtools_frontend_resources_deps += [
     ":copy_karma_conf",
     "test/unittests/front_end/common",
+    "test/unittests/front_end/formatter_worker",
   ]
 }
 
@@ -2304,7 +2320,7 @@ copy("copy_emulated_devices_images") {
 
 copy("copy_lighthouse_locale_files") {
   sources = lighthouse_locale_files
-  outputs = [ "$resources_out_dir/lighthouse_worker/lighthouse/locales/{{source_file_part}}" ]
+  outputs = [ "$resources_out_dir/third_party/lighthouse/locales/{{source_file_part}}" ]
 }
 
 copy("copy_wasm_deps") {

DEPS

@@ -4,13 +4,13 @@
 
 vars = {
   'build_url': 'https://chromium.googlesource.com/chromium/src/build.git',
-  'build_revision': '05fc2f579a9b9044eb6c66f7c076e6fffec9f9f8',
+  'build_revision': 'f0f1f409ecb5e7ce3e4e3ae5ac1f01eb5550837f',
 
   'buildtools_url': 'https://chromium.googlesource.com/chromium/src/buildtools.git',
-  'buildtools_revision': 'ef2f1b324945dd1451ef58653e7723b92dcb23cc',
+  'buildtools_revision': 'fa6ae42dcfbf3bf965439c0bdfeb03cf4e2a5840',
 
   'depot_tools_url': 'https://chromium.googlesource.com/chromium/tools/depot_tools.git',
-  'depot_tools_revision': '29d5cf85ac28d9ef59228e8805ab7b1078baa667',
+  'depot_tools_revision': '9ca9c52c4c04eee136f37bab1404ae0c2319bf06',
 
   'inspector_protocol_url': 'https://chromium.googlesource.com/deps/inspector_protocol',
   'inspector_protocol_revision': '81ef742ba3587767fc08652d299df9e9b7051407',
@@ -23,11 +23,11 @@ vars = {
 
   # Chromium build number for unit tests. It should be regularly updated to
   # the content of https://commondatastorage.googleapis.com/chromium-browser-snapshots/Linux_x64/LAST_CHANGE
-  'chromium_linux': '744926',
+  'chromium_linux': '745768',
   # the content of https://commondatastorage.googleapis.com/chromium-browser-snapshots/Win_x64/LAST_CHANGE
-  'chromium_win': '744921',
+  'chromium_win': '745766',
   # the content of https://commondatastorage.googleapis.com/chromium-browser-snapshots/Mac/LAST_CHANGE
-  'chromium_mac': '744917',
+  'chromium_mac': '745768',
 }
 
 # Only these hosts are allowed for dependencies in this DEPS file.

front_end/Tests.js

@@ -1146,7 +1146,8 @@
       const text = messages[i].messageText;
       if (text === 'PASS') {
         return;
-      } else if (/^FAIL/.test(text)) {
+      }
+      if (/^FAIL/.test(text)) {
         this.fail(text);
       }  // This will throw.
     }

front_end/accessibility/AccessibilityNodeView.js

@@ -211,7 +211,8 @@ export class AXNodePropertyTreeElement extends UI.TreeOutline.TreeElement {
         value.type === AXValueType.NodeList) {
       this.appendRelatedNodeListValueElement(value);
       return;
-    } else if (value.sources) {
+    }
+    if (value.sources) {
       const sources = value.sources;
       for (let i = 0; i < sources.length; i++) {
         const source = sources[i];

front_end/animation/AnimationModel.js

@@ -682,9 +682,8 @@ export class AnimationGroup {
     function extractId(anim) {
       if (anim.type() === Type.WebAnimation) {
         return anim.type() + anim.id();
-      } else {
-        return anim._cssId();
       }
+      return anim._cssId();
     }
 
     if (this._animations.length !== group._animations.length) {