Skip to content

Fix failing tests#159

Merged
PrimozGodec merged 5 commits into
biolab:masterfrom
PrimozGodec:fix-tests
Apr 3, 2023
Merged

Fix failing tests#159
PrimozGodec merged 5 commits into
biolab:masterfrom
PrimozGodec:fix-tests

Conversation

@PrimozGodec
Copy link
Copy Markdown
Collaborator

@PrimozGodec PrimozGodec commented Apr 3, 2023

Issues and Changes
  • Widgets are not PyQt6 compatible - fix PyQt compatibility
  • Some widgets still use get_column_view - use get_column instead
  • One test start to fail due to the difference in the 16th decimal number - use assertAlmostEqual instead of assertEqual
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec merged commit 474dcf6 into biolab:master Apr 3, 2023
@PrimozGodec PrimozGodec deleted the fix-tests branch April 3, 2023 10:56
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.89%. Comparing base (ec0dc2c) to head (2185930).
⚠️ Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   83.01%   82.89%   -0.13%     
==========================================
  Files          18       18              
  Lines        3115     3104      -11     
  Branches      362      360       -2     
==========================================
- Hits         2586     2573      -13     
- Misses        474      478       +4     
+ Partials       55       53       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants