Merge pull request #7129 from janezd/nomogram-report-save-clipboard

Nomogram: Fix reporting, saving image, copying to clipboard

Author: ales-erjavec

Orange/widgets/visualize/ownomogram.py

@@ -18,6 +18,9 @@
 from AnyQt.QtCore import Qt, QRectF, QSize, QPropertyAnimation, QObject, \
     pyqtProperty
 
+from orangewidget.io import ClipboardFormat
+from orangewidget.utils import saveplot
+
 from Orange.data import Table, Domain, DiscreteVariable, ContinuousVariable, \
     Variable
 from Orange.statistics.util import nanmin, nanmax, nanmean, unique
@@ -674,6 +677,10 @@ class Outputs:
     sort_index = Setting(SortBy.ABSOLUTE)
     cont_feature_dim_index = Setting(0)
 
+    # This is defined so that base widget shows the button for saving graph
+    # and connects the shortcut for copying to clipboard. The value itself
+    # is not used because send_report, save_graph and copy_to_clipboard are
+    # overridden.
     graph_name = "scene"  # QGraphicsScene
 
     class Error(OWWidget.Error):
@@ -1302,8 +1309,26 @@ def clear_scene(self):
         self.dot_animator.clear()
         self.scene.clear()
 
+    def get_nomogram_view(self):
+        view = QGraphicsView(self.scene, self)
+        scene_rect = self.scene.itemsBoundingRect()
+        view.setSceneRect(scene_rect)
+        view.resize(scene_rect.size().toSize())
+        return view
+
+    def copy_to_clipboard(self):
+        ClipboardFormat.write_image(None, self.get_nomogram_view())
+
+    def save_graph(self):
+        saveplot.save_plot(self.get_nomogram_view(), self.graph_writers)
+
     def send_report(self):
-        self.report_plot()
+        # self.report_plot(name="", plot=self.get_nomogram_view())
+        # would work, but the resulting nomogram is too small
+        # The drawback of the below is that the space between top_view and view
+        self.report_plot(name="", plot=self.top_view)
+        self.report_plot(name="", plot=self.view)
+        self.report_plot(name="", plot=self.bottom_view)
 
     @staticmethod
     def reconstruct_domain(classifier: Model, preprocessed: Domain) -> Domain:

Orange/widgets/visualize/tests/test_ownomogram.py

@@ -350,6 +350,15 @@ def __call__(self, table):
         lr = LogisticRegressionLearner()(data)
         self.send_signal(self.widget.Inputs.classifier, lr)
 
+    def test_report_copy_save_graph(self):
+        # Test that reporting, copying to clipboard, and saving graph don't crash
+        self.send_signal(self.widget.Inputs.classifier, self.nb_cls)
+        self.widget.send_report()
+        self.widget.copy_to_clipboard()
+        with patch("orangewidget.utils.filedialogs.open_filename_dialog_save") as m:
+            m.return_value = (None, None, None)
+            self.widget.save_graph()
+
 
 if __name__ == "__main__":
     unittest.main()