pylint

Author: janezd

Orange/widgets/data/owfile.py

@@ -9,7 +9,6 @@
     QStyle, QComboBox, QMessageBox, QGridLayout, QLabel, \
     QLineEdit, QSizePolicy as Policy, QCompleter
 from AnyQt.QtCore import Qt, QTimer, QSize, QUrl
-from AnyQt.QtGui import QBrush
 
 from orangewidget.utils.filedialogs import format_filter
 from orangewidget.workflow.drophandler import SingleUrlDropHandler
@@ -327,6 +326,7 @@ def select_file(self, n):
             self.set_file_list()
 
     def select_sheet(self):
+        # pylint: disable=unsubscriptable-object
         self.recent_paths[0].sheet = self.sheet_combo.currentText()
         self.load_data()
 
@@ -339,7 +339,7 @@ def select_reader(self, n):
             return  # ignore for URL's
 
         if self.recent_paths:
-            path = self.recent_paths[0]
+            path = self.recent_paths[0]  # pylint: disable=unsubscriptable-object
             if n == 0:  # default
                 path.file_format = None
             elif n <= len(self.available_readers):
@@ -384,6 +384,7 @@ def browse_file(self, in_demos=False):
             return
         self.add_path(filename)
         if reader is not None:
+            # pylint: disable=unsubscriptable-object
             self.recent_paths[0].file_format = reader.qualified_name()
 
         self.source = self.LOCAL_FILE
@@ -479,6 +480,7 @@ def _get_reader(self) -> FileFormat:
             path = self.last_path()
             self.reader_combo.setEnabled(True)
 
+            # pylint: disable=unsubscriptable-object
             if self.recent_paths and self.recent_paths[0].file_format:
                 qname = self.recent_paths[0].file_format
                 qname_index = {r.qualified_name(): i for i, r in enumerate(self.available_readers)}
@@ -508,6 +510,7 @@ def _get_reader(self) -> FileFormat:
                     self.select_reader(old_idx)
                     return self._get_reader()
 
+            # pylint: disable=unsubscriptable-object
             if self.recent_paths and self.recent_paths[0].sheet:
                 reader.select_sheet(self.recent_paths[0].sheet)
             return reader
@@ -597,10 +600,12 @@ def _describe(table):
         return text
 
     def storeSpecificSettings(self):
+        # pylint: disable=unsubscriptable-object
         self.current_context.modified_variables = self.variables[:]
 
     def retrieveSpecificSettings(self):
         if hasattr(self.current_context, "modified_variables"):
+            # pylint: disable=unsubscriptable-object
             self.variables[:] = self.current_context.modified_variables
 
     def reset_domain_edit(self):

Orange/widgets/data/tests/test_owfile.py

@@ -1,6 +1,5 @@
 # Test methods with long descriptive names can omit docstrings
 # pylint: disable=missing-docstring,protected-access,too-many-public-methods
-import os
 from os import path, remove, getcwd
 from os.path import dirname
 import unittest
@@ -24,7 +23,7 @@
     Domain, DiscreteVariable, ContinuousVariable
 from Orange.util import OrangeDeprecationWarning
 
-from Orange.data.io import TabReader, XlsReader
+from Orange.data.io import TabReader
 from Orange.tests import named_file
 from Orange.widgets.data.owfile import OWFile, OWFileDropHandler, DEFAULT_READER_TEXT
 from Orange.widgets.utils.filedialogs import dialog_formats, format_filter, RecentPath
@@ -42,7 +41,9 @@ class FailedSheetsFormat(FileFormat):
     def read(self):
         pass
 
+    @property
     def sheets(self):
+        # pylint: disable=broad-exception-raised
         raise Exception("Not working")
 
 
@@ -138,6 +139,7 @@ def _drop_event(self, url):
     def test_check_file_size(self):
         self.assertFalse(self.widget.Warning.file_too_big.is_shown())
         self.widget.SIZE_LIMIT = 4000
+        # We're avoiding __new__, pylint: disable=unnecessary-dunder-call
         self.widget.__init__()
         self.assertTrue(self.widget.Warning.file_too_big.is_shown())
 
@@ -338,7 +340,9 @@ def test_check_datetime_disabled(self):
         with named_file(dat, suffix=".tab") as filename:
             self.open_dataset(filename)
             domain_editor = self.widget.domain_editor
-            idx = lambda x: self.widget.domain_editor.model().createIndex(x, 1)
+
+            def idx(x):
+                return self.widget.domain_editor.model().createIndex(x, 1)
 
             qcombobox = QComboBox()
             combo = ComboDelegate(domain_editor,
@@ -466,7 +470,7 @@ def test_select_reader(self):
 
     def test_auto_detect_and_override(self):
         tab_as_xlsx = FileFormat.locate("actually-a-tab-file.xlsx",
-                                        os.path.split(__file__)[0])
+                                        path.split(__file__)[0])
         iris = FileFormat.locate("iris", dataset_dirs)
 
         reader_combo = self.widget.reader_combo