OWFeatureStatistics: pylint fixes

Author: pavlin-policar

Orange/widgets/data/owfeaturestatistics.py

@@ -154,7 +154,9 @@ def set_data(self, data):
         self.target_var = None
 
         self.__attributes = self.__filter_attributes(domain.attributes, self.table.X)
-        self.__class_vars = self.__filter_attributes(domain.class_vars, self.table._Y)
+        # We disable pylint warning because the `Y` property squeezes vectors,
+        # while we need a 2d array, which `_Y` provides
+        self.__class_vars = self.__filter_attributes(domain.class_vars, self.table._Y)  # pylint: disable=protected-access
         self.__metas = self.__filter_attributes(domain.metas, self.table.metas)
 
         self.n_attributes = len(self.variables)
@@ -349,7 +351,7 @@ def sortColumnData(self, column):
         var_name_indices = np.argsort(self._variable_names)
 
         # Prepare vartype indices so ready when needed
-        disc_idx, cont_idx, time_idx, str_idx = self._attr_indices(self.variables)
+        disc_idx, _, time_idx, str_idx = self._attr_indices(self.variables)
 
         # Sort by: (type)
         if column == self.Columns.ICON:
@@ -395,6 +397,8 @@ def sortColumnData(self, column):
         elif column == self.Columns.MISSING:
             return self._missing
 
+        return None
+
     def _sortColumnData(self, column):
         """Allow sorting with 2d arrays."""
         data = np.asarray(self.sortColumnData(column))
@@ -437,10 +441,16 @@ def headerData(self, section, orientation, role):
             if role == Qt.DisplayRole:
                 return self.Columns.from_index(section).name
 
+        return None
+
     def data(self, index, role):
         # type: (QModelIndex, Qt.ItemDataRole) -> Any
+        # Text formatting for various data simply requires a lot of branches.
+        # This is much better than overengineering various formatters...
+        # pylint: disable=too-many-branches
+
         if not index.isValid():
-            return
+            return None
 
         row, column = self.mapToSourceRows(index.row()), index.column()
         # Make sure we're not out of range
@@ -660,6 +670,9 @@ def paint(self, painter, option, index):
 
         scene.render(painter, target=QRectF(option.rect), mode=Qt.IgnoreAspectRatio)
 
+        # pylint complains about inconsistent return statements
+        return None
+
 
 class OWFeatureStatistics(widget.OWWidget):
     name = 'Feature Statistics'
@@ -812,7 +825,11 @@ def _format_variables_string(self, variables):
                 ('time', TimeVariable),
                 ('string', StringVariable)
         ]:
-            var_type_list = [v for v in variables if type(v) is var_type]
+            # Disable pylint here because a `TimeVariable` is also a
+            # `ContinuousVariable`, and should be labelled as such. That is why
+            # it is necessary to check the type this way instead of using
+            # `isinstance`, which would fail in the above case
+            var_type_list = [v for v in variables if type(v) is var_type]  # pylint: disable=unidiomatic-typecheck
             if var_type_list:
                 shown = var_type in self.model.HIDDEN_VAR_TYPES
                 agg.append((

Orange/widgets/data/tests/test_owfeaturestatistics.py

@@ -187,7 +187,7 @@ def _wrapper(self):
     return _wrapper
 
 
-class TestOWFeatureStatisticsTableTypes(WidgetTest):
+class TestVariableTypes(WidgetTest):
     def setUp(self):
         self.widget = self.create_widget(
             OWFeatureStatistics, stored_settings={'auto_commit': False}

Orange/widgets/data/utils/histogram.py

@@ -124,6 +124,8 @@ class Histogram(QGraphicsWidget):
     def __init__(self, data, variable, parent=None, height=200,
                  width=300, side_padding=5, top_padding=20, bar_spacing=4,
                  border=0, border_color=None, color_attribute=None, n_bins=10):
+        # The price of flexibility is complexity...
+        # pylint: disable=too-many-instance-attributes
         super().__init__(parent)
         self.height, self.width = height, width
         self.padding = side_padding