Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/ubuntu compatibility #55

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix/ubuntu compatibility #55

wants to merge 4 commits into from

Conversation

joonkim0625
Copy link

@joonkim0625 joonkim0625 commented Oct 9, 2023 •
edited
Loading

  • Remove the unsafe string force option from Makefile
  • Replace String module with Bytes module
  • Add return types to functions
  • Fix unhandled syscalls

@joonkim0625
Remove unsafe string force option from Makefile
c42016b
@joonkim0625
Replace String moduels with Bytes module
695ee4b 
Reference: https://v2.ocaml.org/api/String.html

>Past mutability. Before OCaml 4.02, strings used to be modifiable in place like Bytes.t mutable sequences of bytes. OCaml 4 had various compiler flags and configuration options to support the transition period from mutable to immutable strings. Those options are no longer available, and strings are now always immutable.

To maintain compatibility with newer versions of OCaml, particularly those
embraced by modern Ubuntu versions, we've migrated from using the mutable
'String' module to the 'Bytes' module, which supports mutable byte sequences.
This transition ensures that the codebase remains compatibleon recent OCaml
versions.
@joonkim0625
Add return types to functions
23d0800
@joonkim0625
Fix unhandled syscalls
ed4bec3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joonkim0625