Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate pinning genql dependencies to specific versions #355

Open
3 tasks
coderabbitai bot opened this issue Jan 28, 2025 · 0 comments
Open
3 tasks

Evaluate pinning genql dependencies to specific versions #355

coderabbitai bot opened this issue Jan 28, 2025 · 0 comments
Assignees

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2025

Context

Currently, the genql dependencies in packages/mb-genql/package.json are set to "latest":

  • @genql/cli
  • @genql/runtime
  • genql

Discussion

These dependencies are primarily used for TypeScript generation. While using "latest" versions could potentially lead to unexpected breaking changes and make builds non-reproducible, the following factors were considered:

  • The packages haven't changed much recently
  • They are used specifically for TS generation
  • The impact of potential breaking changes is limited to the build process

References

Action Items

  • Monitor the stability of these dependencies
  • Consider pinning to specific versions if issues arise
  • Document any breaking changes encountered

/cc @AndlerRL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant