You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
14405e8 doc: test: update TestShell instructions (ismaelsadeeq)
Pull request description:
Fixes #27904
From #27904 and IRC.
Update [Testshell instructions ](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test-shell.md#2-importing-testshell-from-the-bitcoin-core-repository)
E.g `TestShell.setup()` throws
```
AttributeError: type object 'TestShell' has no attribute 'setup'
```
Parentheses are missing, it should be `TestShell().setup()`
ACKs for top commit:
Sjors:
utACK 14405e8
brunoerg:
crACK 14405e8
hernanmarino:
utACK 14405e8
Tree-SHA512: ffe5fa1103a3b00ef0ee99879adae967b0da07cb8f8451c4c261b0a70b3b666af7aeaacd6f46f85a84ee5e9c7c7ed49700209b5b1f124d7a76efc420ad5c9cd9
The `TestShell` object initializes with the default settings inherited from the
164
164
`BitcoinTestFramework` class. The user can override these in
165
-
`TestShell.setup(key=value)`.
165
+
`TestShell().setup(key=value)`.
166
166
167
-
**Note:**`TestShell.reset()` will reset test parameters to default values and
167
+
**Note:**`TestShell().reset()` will reset test parameters to default values and
168
168
can be called after the TestShell is shut down.
169
169
170
170
| Test parameter key | Default Value | Description |
@@ -181,7 +181,7 @@ can be called after the TestShell is shut down.
181
181
|`perf`| False | Profiles running nodes with `perf` for the duration of the test if set to `True`. |
182
182
|`rpc_timeout`|`60`| Sets the RPC server timeout for the underlying bitcoind processes. |
183
183
|`setup_clean_chain`|`False`| A 200-block-long chain is initialized from cache by default. Instead, `setup_clean_chain` initializes an empty blockchain if set to `True`. |
184
-
|`randomseed`| Random Integer |`TestShell.options.randomseed` is a member of `TestShell` which can be accessed during a test to seed a random generator. User can override default with a constant value for reproducible test runs. |
184
+
|`randomseed`| Random Integer |`TestShell().options.randomseed` is a member of `TestShell` which can be accessed during a test to seed a random generator. User can override default with a constant value for reproducible test runs. |
185
185
|`supports_cli`|`False`| Whether the bitcoin-cli utility is compiled and available for the test. |
186
186
|`tmpdir`|`"/var/folders/.../"`| Sets directory for test logs. Will be deleted upon a successful test run unless `nocleanup` is set to `True`|
187
187
|`trace_rpc`|`False`| Logs all RPC calls if set to `True`. |
0 commit comments