Skip to content

Commit b147322

Browse files
committed
Use PACKAGE_NAME in messages rather than hardcoding "Bitcoin Core"
1 parent 80d1598 commit b147322

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/init.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1663,7 +1663,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
16631663

16641664
const auto BadPortWarning = [](const char* prefix, uint16_t port) {
16651665
return strprintf(_("%s request to listen on port %u. This port is considered \"bad\" and "
1666-
"thus it is unlikely that any Bitcoin Core peers connect to it. See "
1666+
"thus it is unlikely that any peer will connect to it. See "
16671667
"doc/p2p-bad-ports.md for details and a full list."),
16681668
prefix,
16691669
port);

src/qt/forms/optionsdialog.ui

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@
286286
<item>
287287
<widget class="QLineEdit" name="externalSignerPath">
288288
<property name="toolTip">
289-
<string>Full path to a Bitcoin Core compatible script (e.g. C:\Downloads\hwi.exe or /Users/you/Downloads/hwi.py). Beware: malware can steal your coins!</string>
289+
<string>Full path to a %1 compatible script (e.g. C:\Downloads\hwi.exe or /Users/you/Downloads/hwi.py). Beware: malware can steal your coins!</string>
290290
</property>
291291
</widget>
292292
</item>

src/qt/optionsdialog.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,9 @@ OptionsDialog::OptionsDialog(QWidget *parent, bool enableWallet) :
9191
ui->thirdPartyTxUrls->setVisible(false);
9292
}
9393

94-
#ifndef ENABLE_EXTERNAL_SIGNER
94+
#ifdef ENABLE_EXTERNAL_SIGNER
95+
ui->externalSignerPath->setToolTip(ui->externalSignerPath->toolTip().arg(PACKAGE_NAME));
96+
#else
9597
//: "External signing" means using devices such as hardware wallets.
9698
ui->externalSignerPath->setToolTip(tr("Compiled without external signing support (required for external signing)"));
9799
ui->externalSignerPath->setEnabled(false);

0 commit comments

Comments
 (0)