Skip to content

Commit c056735

Browse files
author
MacroFake
committed
Merge bitcoin/bitcoin#26358: doc: Rearrange a few lines in the dependency graph of libraries
1184a66 doc: Rearrange some lines in the dependency graph of libraries (Stacie Waleyko) Pull request description: In this PR, I've attempted to improve readability in the [dependency graph of libraries](https://github.com/bitcoin/bitcoin/blob/master/doc/design/libraries.md) by untangling a few crossed lines. I'm not sure if this is that big of an improvement but wanted to throw it out there. I used an extremely scientific method of manually counting the number of crossed lines in the original diagram and got 15. This PR reduces that number down to about 10. I also changed the curve of the lines to "basis" which rounds the edges out. Again, not sure if it really is that much of an improvement, but it seems marginally easier on the eyes. Here is what the new graph looks like rendered: ![Screenshot from 2022-10-20 22-09-30](https://user-images.githubusercontent.com/1823216/197095545-5fc90cce-a817-4db2-a0f5-1a8a95380b70.png) The changes can be verified independently with [Mermaid](https://mermaid-js.github.io/mermaid/#/), with the easiest way being the online editor: https://mermaid.live/ I did try moving some more stuff around, particularly the top level of library callers, but was not able to simplify the graph any further. ACKs for top commit: shaavan: ACK 1184a66 Tree-SHA512: 61d33d68c1e6fa354aebdda5e06e9c7a722ca20886c6acc30dd08af7133d737130d7a646d87f9e5a8ae0bc5a5aabfbc64ded9ee04dfeed8f23d948444add916b
2 parents 50cc8ef + 1184a66 commit c056735

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

doc/design/libraries.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
```mermaid
3737
38-
%%{ init : { "flowchart" : { "curve" : "linear" }}}%%
38+
%%{ init : { "flowchart" : { "curve" : "basis" }}}%%
3939
4040
graph TD;
4141
@@ -51,18 +51,18 @@ bitcoin-qt[bitcoin-qt]-->libbitcoin_wallet;
5151
bitcoin-wallet[bitcoin-wallet]-->libbitcoin_wallet;
5252
bitcoin-wallet[bitcoin-wallet]-->libbitcoin_wallet_tool;
5353
54-
libbitcoin_cli-->libbitcoin_common;
5554
libbitcoin_cli-->libbitcoin_util;
55+
libbitcoin_cli-->libbitcoin_common;
5656
57-
libbitcoin_common-->libbitcoin_util;
5857
libbitcoin_common-->libbitcoin_consensus;
58+
libbitcoin_common-->libbitcoin_util;
5959
6060
libbitcoin_kernel-->libbitcoin_consensus;
6161
libbitcoin_kernel-->libbitcoin_util;
6262
63-
libbitcoin_node-->libbitcoin_common;
6463
libbitcoin_node-->libbitcoin_consensus;
6564
libbitcoin_node-->libbitcoin_kernel;
65+
libbitcoin_node-->libbitcoin_common;
6666
libbitcoin_node-->libbitcoin_util;
6767
6868
libbitcoinqt-->libbitcoin_common;
@@ -71,8 +71,8 @@ libbitcoinqt-->libbitcoin_util;
7171
libbitcoin_wallet-->libbitcoin_common;
7272
libbitcoin_wallet-->libbitcoin_util;
7373
74-
libbitcoin_wallet_tool-->libbitcoin_util;
7574
libbitcoin_wallet_tool-->libbitcoin_wallet;
75+
libbitcoin_wallet_tool-->libbitcoin_util;
7676
7777
classDef bold stroke-width:2px, font-weight:bold, font-size: smaller;
7878
class bitcoin-qt,bitcoind,bitcoin-cli,bitcoin-wallet bold

0 commit comments

Comments
 (0)