Skip to content

Commit c2ff87e

Browse files
committed
Merge bitcoin/bitcoin#28150: test: Avoid intermittent issues due to async events in validationinterface_tests
faca9a3 test: Avoid intermittent issues due to async events in validationinterface_tests (MarcoFalke) Pull request description: Currently the tests have many issues: * They setup the genesis block, even though it is not needed * They queue an async `UpdatedBlockTip` even, which causes intermittent issues: bitcoin/bitcoin#28146 (comment) Fix all issues by trimming down the setup to just `ChainTestingSetup`. ACKs for top commit: Crypt-iQ: tACK faca9a3 Tree-SHA512: 4449040330f89bbaf5ce5b2052417c160b451c373987fdf1069596c07834ed81f0aea1506d53c7d2cd21062b27332d30679285dae194b272fd0cb9ce5ded32cf
2 parents 4517e2f + faca9a3 commit c2ff87e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/test/validationinterface_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
#include <atomic>
1414

15-
BOOST_FIXTURE_TEST_SUITE(validationinterface_tests, TestingSetup)
15+
BOOST_FIXTURE_TEST_SUITE(validationinterface_tests, ChainTestingSetup)
1616

1717
struct TestSubscriberNoop final : public CValidationInterface {
1818
void BlockChecked(const CBlock&, const BlockValidationState&) override {}

0 commit comments

Comments
 (0)