Skip to content

Commit ca759bc

Browse files
committed
Merge #20200: doc: rename CODEOWNERS to REVIEWERS
86e6add doc: rename CODEOWNERS to REVIEWERS (Adam Jonas) Pull request description: This PR renames the CODEOWNERS file to REVIEWERS and works with DrahtBot to leave a comment requesting a review. Testing of the functionality was done on https://github.com/adamjonas/bitcoin-codeowners-sandbox/pulls. ~EDIT: [after further testing of a fake organization](https://github.com/jonasorg/bitcoin-codeowners-sandbox-org/pulls), it appears that in order to be automatically tagged, the reviewer requires write level permissions. This is undocumented and will obviously close the circle of who can be tagged and so this PR reverts the addition of the file in #18949.~ ~This removes a line not being parsed in the CODEOWNERS file introduced in #18949. While the pattern [checked out](bitcoin/bitcoin#18949 (comment)) using `git ls-files`, it is preventing the CODEOWNERS file from automatically tagging reviewers. For future modifications to this file, note that [any line failing to parse causes the entire file to stop identifying codeowners](http://www.benjaminoakes.com/git/2018/08/10/Testing-changes-to-GitHub-CODEOWNERS/#:~:text=warning).~ ~I experimented in a [sandbox repo](https://github.com/adamjonas/bitcoin-codeowners-sandbox/pulls) to discover the offending line and this change appears to fix the problem.~ ACKs for top commit: laanwj: Doesn't look like github is going to fix this any time soon and besides REVIEWERS is a better name so ACK 86e6add Tree-SHA512: b3425eca4be62f829f0edcfa08232df310680835c2f60e9fa36956a6b59a2b0cd0ab580c572c87affccd843fbd849f4f99e4b3d9d7b6070ab117953f04e17f5a
2 parents 257cf05 + 86e6add commit ca759bc

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

CODEOWNERS renamed to REVIEWERS

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,15 @@
11
# ==============================================================================
2-
# Bitcoin Core CODEOWNERS
2+
# Bitcoin Core REVIEWERS
33
# ==============================================================================
44

5-
# Configuration of code ownership and review approvals for the bitcoin/bitcoin
6-
# repo.
5+
# Configuration of automated review requests for the bitcoin/bitcoin repo
6+
# via DrahtBot.
77

8-
# Order is important; the last matching pattern takes the most precedence.
9-
# More info on how this file works can be found at:
10-
# https://help.github.com/articles/about-codeowners/
8+
# Order is not important; if a modified file or directory matches a fnmatch,
9+
# the reviewer will be mentioned in a PR comment requesting a review.
1110

12-
# This file is called CODEOWNERS because it is a magic file for GitHub to
13-
# automatically suggest reviewers. In this project's case, the names below
14-
# should be thought of as code reviewers rather than owners. Regular
15-
# contributors are free to add their names to specific directories or files
16-
# provided that they are willing to provide a review when automatically
17-
# assigned.
11+
# Regular contributors are free to add their names to specific directories or
12+
# files provided that they are willing to provide a review.
1813

1914
# Absence from this list should not be interpreted as a discouragement to
2015
# review a pull request. Peer review is always welcome and is a critical
@@ -23,12 +18,12 @@
2318

2419

2520
# Maintainers
26-
# @laanwj
27-
# @sipa
2821
# @fanquake
2922
# @jonasschnelli
23+
# @laanwj
3024
# @marcofalke
3125
# @meshcollider
26+
# @sipa
3227

3328
# Docs
3429
/doc/*[a-zA-Z-].md @harding

0 commit comments

Comments
 (0)