[addrman] [tests] Tidy up unused arguments in addrman test functions

jnewbery · jnewbery · commit d02098d1f042 · 2021-11-09T17:09:50.000Z
diff --git a/src/test/addrman_tests.cpp b/src/test/addrman_tests.cpp
@@ -84,13 +84,13 @@ class AddrManTest : public AddrMan
         : AddrMan(asmap, /*deterministic=*/true, /* consistency_check_ratio */ 100)
     {}
 
-    AddrInfo* Find(const CService& addr, int* pnId = nullptr)
+    AddrInfo* Find(const CService& addr)
     {
         LOCK(m_impl->cs);
-        return m_impl->Find(addr, pnId);
+        return m_impl->Find(addr);
     }
 
-    AddrInfo* Create(const CAddress& addr, const CNetAddr& addrSource, int* pnId = nullptr)
+    AddrInfo* Create(const CAddress& addr, const CNetAddr& addrSource, int* pnId)
     {
         LOCK(m_impl->cs);
         return m_impl->Create(addr, addrSource, pnId);

Original file line number	Diff line number	Diff line change
`@@ -84,13 +84,13 @@ class AddrManTest : public AddrMan`
`84`	`84`	`: AddrMan(asmap, /deterministic=/true, /* consistency_check_ratio */ 100)`
`85`	`85`	`{}`
`86`	`86`
`87`		`- AddrInfo* Find(const CService& addr, int* pnId = nullptr)`
	`87`	`+ AddrInfo* Find(const CService& addr)`
`88`	`88`	`{`
`89`	`89`	`LOCK(m_impl->cs);`
`90`		`- return m_impl->Find(addr, pnId);`
	`90`	`+ return m_impl->Find(addr);`
`91`	`91`	`}`
`92`	`92`
`93`		`- AddrInfo* Create(const CAddress& addr, const CNetAddr& addrSource, int* pnId = nullptr)`
	`93`	`+ AddrInfo* Create(const CAddress& addr, const CNetAddr& addrSource, int* pnId)`
`94`	`94`	`{`
`95`	`95`	`LOCK(m_impl->cs);`
`96`	`96`	`return m_impl->Create(addr, addrSource, pnId);`