Skip to content

Commit daebf9e

Browse files
committed
Merge bitcoin-core/gui#705: doc: Fix comment about how wallet txs are sorted
c497a19 Fix comment about how wallet txs are sorted (John Moffett) Pull request description: The wallet transactions in the node are not sorted by txid (or any hash) since bitcoin/bitcoin#24699. This is how they're stored in memory now: https://github.com/bitcoin-core/gui/blob/835212cd1d8f8fc7f19775f5ff8cc21c099122b2/src/wallet/wallet.h#L397-L399 ACKs for top commit: achow101: ACK c497a19 jarolrod: ACK c497a19 Tree-SHA512: e72559991688452ef254474d4235dc75fac655bce04909c3a0eece907360f4c6f57707db9b4373a4bd2271b23c57e863684c33e0728adf48e477c5499cdfdad7
2 parents aaa5597 + c497a19 commit daebf9e

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/qt/transactiontablemodel.cpp

+1-4
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,7 @@ class TransactionTablePriv
9393

9494
TransactionTableModel *parent;
9595

96-
/* Local cache of wallet.
97-
* As it is in the same order as the CWallet, by definition
98-
* this is sorted by sha256.
99-
*/
96+
//! Local cache of wallet sorted by transaction hash
10097
QList<TransactionRecord> cachedWallet;
10198

10299
/** True when model finishes loading all wallet transactions on start */

0 commit comments

Comments
 (0)