Skip to content

Commit f2074ee

Browse files
author
MarcoFalke
committed
Merge bitcoin/bitcoin#23601: Don't check if the listening socket is valid
6c9ee92 net: don't check if the listening socket is valid (Vasil Dimov) Pull request description: _This is a piece of #21878, chopped off to ease review._ Listening sockets in `CConnman::vhListenSocket` are always valid (underlying file descriptor is not `INVALID_SOCKET`). ACKs for top commit: theStack: Code-review ACK 6c9ee92 🔌 Tree-SHA512: b2e29711c6a0c7c85467ca61cfd7fb734eb06bd83a41f88735901caf90aec095ca80707ce5bb897d39c80fdec16819dbf5a84979c9b1ab3dc3fb8b08cebe7c61
2 parents 9174bcf + 6c9ee92 commit f2074ee

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/net.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1640,7 +1640,7 @@ void CConnman::SocketHandlerListening(const std::set<SOCKET>& recv_set)
16401640
if (interruptNet) {
16411641
return;
16421642
}
1643-
if (listen_socket.socket != INVALID_SOCKET && recv_set.count(listen_socket.socket) > 0) {
1643+
if (recv_set.count(listen_socket.socket) > 0) {
16441644
AcceptConnection(listen_socket);
16451645
}
16461646
}

0 commit comments

Comments
 (0)