Skip to content

Commit f998eb7

Browse files
committed
Merge bitcoin/bitcoin#27683: ci: remove RUN_SECURITY_TESTS
6a93658 ci: remove RUN_SECURITY_TESTS (fanquake) Pull request description: We no-longer run any security/symbol checks in the CI, and doubt we will in future (if we do, it'll be via Guix, where this var would be redundant in any case). The CI environment doesn't (exactly) match the release build environment (and is semi-regularly changing), and the binaries produced in the CI don't match how we build release binaries, so there is no point trying to run these checks, especially as we add more involved tests, i.e #26953. ACKs for top commit: josibake: code review ACK bitcoin/bitcoin@6a93658 TheCharlatan: ACK 6a93658 Tree-SHA512: c0eec61a4b873bac487ba9321b50116a215b4796bd7d416d98ffcd09969dbf635c2cb5aeb225c89d1e6462838fa2a48565048ebe730f48d76d3db46b64855a91
2 parents 9a8318f + 6a93658 commit f998eb7

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

ci/test/00_setup_env.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ export USE_BUSY_BOX=${USE_BUSY_BOX:-false}
3737
export RUN_UNIT_TESTS=${RUN_UNIT_TESTS:-true}
3838
export RUN_FUNCTIONAL_TESTS=${RUN_FUNCTIONAL_TESTS:-true}
3939
export RUN_TIDY=${RUN_TIDY:-false}
40-
export RUN_SECURITY_TESTS=${RUN_SECURITY_TESTS:-false}
4140
# By how much to scale the test_runner timeouts (option --timeout-factor).
4241
# This is needed because some ci machines have slow CPU or disk, so sanitizers
4342
# might be slow or a reindex might be waiting on disk IO.

ci/test/06_script_b.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,6 @@ if [ "${RUN_TIDY}" = "true" ]; then
173173
git --no-pager diff
174174
fi
175175

176-
if [ "$RUN_SECURITY_TESTS" = "true" ]; then
177-
make test-security-check
178-
fi
179-
180176
if [ "$RUN_FUZZ_TESTS" = "true" ]; then
181177
bash -c "LD_LIBRARY_PATH=${DEPENDS_DIR}/${HOST}/lib test/fuzz/test_runner.py ${FUZZ_TESTS_CONFIG} $MAKEJOBS -l DEBUG ${DIR_FUZZ_IN}"
182178
fi

0 commit comments

Comments
 (0)