Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most comments from original PR don't seem to be reflected in copied PR #44

Open
harding opened this issue Jul 18, 2024 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@harding
Copy link

harding commented Jul 18, 2024

I've tried two PRs with Fresh Eyes and very few of the code comments from the original PR seem to be reflected my local Fresh Eyes PR.

Steps to reproduce:

  1. Go to https://fresh-eyes.vercel.app and complete all the initial authorization steps
  2. Enter the following details: bitcoin / bitcoin / 29242
  3. Be redirected to [FreshEyes] Mempool util: Add RBF diagram checks for single chunks against clusters of size 2 harding/bitcoin#2

What I see: my copied version of the PR only has two GitHub inline comments added, each of which refers to a short thread.

What I expect to see: references to at least the two dozen threads that exist on the original PR with its final commits. Ideally, several dozen more references to threads on earlier versions of the commits (although I acknowledge that's more difficult).

@IgboPharaoh
Copy link
Collaborator

IgboPharaoh commented Jul 25, 2024

Thank you very much for taking the time to use our product and for bringing this issue to our attention.

FreshEyes is designed to reproduce the pull request you're working on and aggregate all comments into different sections to streamline the review process:

  • Issue comments, review comments, and outdated reviews not attached to any specific code or diff are aggregated into a single inline comment. The FreshEyes bot displays the total count, e.g.,
    There were 8 comments left by 5 reviewers, 1 bot, and the author for this pull request.
    This approach aims to enhance review efficiency by minimising the noise from these comments.

  • Comments attached to specific lines of code are not aggregated. Instead, we restructure them by adding links to the comments made by everyone in that thread, as these are considered relevant for the reviewer.

Nevertheless I have taken note of the issue pointed out and also looked at your replicated version. I will replicate the pull request you mentioned to investigate this issue further and work on how we can better structure these comments based on your suggestions.

@Extheoisah Extheoisah added the bug Something isn't working label Jul 29, 2024
@IgboPharaoh
Copy link
Collaborator

Apologies this is coming late and we've not updated you on the progress of this issue.

Currently, we have a draft pull request aimed towards solving this but it has been put on hold as focus has been directed towards other projects. Please be rest assured this will be addressed in due time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants