Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Interaction between simulation file path and results directory #217

Open
carlaKC opened this issue Feb 7, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@carlaKC
Copy link
Contributor

carlaKC commented Feb 7, 2025

Describe the bug

If you run the simulator with two relative paths, it'll look for the simulation file in the data dir rather than the path provided and fail:

sim-cli --clock-speedup 1000 -s "lvl_acinq/simln_peacetime.json" -d "lvl_acinq/peacetime/"

[sim_cli::parsing] Simulation file 'lvl_acinq/peacetime/lvl_acinq/simln_peacetime.json' does not exist.
Error: no simulation files found in /Users/carla/Work/jam-ln/data/lvl_acinq/peacetime.

We should check whether we've got a simfile first and only fall back to the dir if it's not specified.

@carlaKC carlaKC added the bug Something isn't working label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant