Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IP addresses #189

Closed
josibake opened this issue Oct 31, 2023 · 2 comments
Closed

Fix IP addresses #189

josibake opened this issue Oct 31, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone
k8s

Comments

@josibake
Copy link
Collaborator

Currently, we still have a method that randomly generates a fake IP address if Tank._ipv4 is None. To get around this, I'm waiting for the pods to spin up and then getting the IP and setting it on the tank, which is pretty gross and will be super slow when spinning up 100s of nodes. We should move all the IP functions into the abstract base class , and grab the IP directly from the container when we need it (same as we were doing in docker land).
@josibake josibake added this to the k8s milestone Oct 31, 2023
@TChukwuleta TChukwuleta mentioned this issue Dec 7, 2023
Closed
@willcl-ark willcl-ark added the enhancement New feature or request label Jan 11, 2024
@willcl-ark willcl-ark mentioned this issue Feb 8, 2024
Closed
@willcl-ark
Copy link
Contributor

I think this would be moot with #303

What did you want IP addresses for? We using hostnames now yo!

@willcl-ark
Copy link
Contributor

Closing as we use hostnames externally and patches on bitcoind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
The Bitcoin Development Project Roadmap
Archived in project
Milestone
k8s
Development

Successfully merging a pull request may close this issue.

Remove ip generator code willcl-ark/warnet
2 participants
@willcl-ark @josibake