Skip to content

Commit 5344bd2

Browse files
committed
Remove bluebird Promise
1 parent eceaf2a commit 5344bd2

13 files changed

+21
-32
lines changed

examples/rest2/claim_positions.js

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict'
22

3-
const Promise = require('bluebird')
43
const { RESTv2 } = require('../../index')
54
const _isEmpty = require('lodash/isEmpty')
65
const { args: { apiKey, apiSecret }, debug, debugTable, readline } = require('../util/setup')

examples/rest2/submit_funding_offer.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict'
22

3-
const Promise = require('bluebird')
43
const { FundingOffer } = require('bfx-api-node-models')
54
const { RESTv2 } = require('../../index')
65
const { args: { apiKey, apiSecret }, debug } = require('../util/setup')
@@ -31,7 +30,7 @@ async function execute () {
3130

3231
debug('done. closing in %ds...', CLOSE_DELAY_MS / 1000)
3332

34-
await Promise.delay(CLOSE_DELAY_MS)
33+
await new Promise(resolve => setTimeout(resolve, CLOSE_DELAY_MS))
3534
await fo.close()
3635

3736
debug('offer closed')

examples/rest2/submit_order.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict'
22

3-
const Promise = require('bluebird')
43
const { Order } = require('bfx-api-node-models')
54
const { RESTv2 } = require('../../index')
65
const { args: { apiKey, apiSecret }, debug, readline } = require('../util/setup')
@@ -66,7 +65,7 @@ async function execute () {
6665
debug('')
6766
debug('will update price to $3.00 in %fs...', UPDATE_DELAY_MS / 1000)
6867

69-
await Promise.delay(UPDATE_DELAY_MS)
68+
await new Promise(resolve => setTimeout(resolve, UPDATE_DELAY_MS))
7069

7170
debug('')
7271
debug('updating order price...')
@@ -76,7 +75,7 @@ async function execute () {
7675
debug('')
7776
debug('will cancel the order in %fs', CANCEL_DELAY_MS / 1000)
7877

79-
await Promise.delay(CANCEL_DELAY_MS)
78+
await new Promise(resolve => setTimeout(resolve, CANCEL_DELAY_MS))
8079

8180
debug('')
8281
debug('cancelling order...')

examples/ws2/calc.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict'
22

3-
const Promise = require('bluebird')
43
const { args: { apiKey, apiSecret }, debug } = require('../util/setup')
54
const WSv2 = require('../../lib/transports/ws2')
65

@@ -13,7 +12,7 @@ async function execute () {
1312
await ws.open()
1413
await ws.auth()
1514

16-
await Promise.delay(5 * 1000)
15+
await new Promise(resolve => setTimeout(resolve, 5 * 1000))
1716

1817
ws.requestCalc([
1918
'margin_sym_tBTCUSD',
@@ -25,7 +24,7 @@ async function execute () {
2524
// Watch log output for balance update packets (wu, miu, etc)
2625
debug('sent calc, closing in 3s...')
2726

28-
await Promise.delay(3 * 1000)
27+
await new Promise(resolve => setTimeout(resolve, 3 * 1000))
2928
await ws.close()
3029
}
3130

examples/ws2/cancel_all.js

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict'
22

3-
const Promise = require('bluebird')
43
const _isEmpty = require('lodash/isEmpty')
54
const { args: { apiKey, apiSecret }, debug, readline } = require('../util/setup')
65
const WSv2 = require('../../lib/transports/ws2')

examples/ws2/oco-order.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict'
22

3-
const Promise = require('bluebird')
43
const { Order } = require('bfx-api-node-models')
54
const { args: { apiKey, apiSecret }, debug } = require('../util/setup')
65
const WSv2 = require('../../lib/transports/ws2')
@@ -45,7 +44,7 @@ async function execute () {
4544
debug('got submit confirmation for order %d [%d]', o.cid, o.id)
4645

4746
// wait a bit...
48-
await Promise.delay(2 * 1000)
47+
await new Promise(resolve => setTimeout(resolve, 2 * 1000))
4948

5049
if (orderClosed) {
5150
return debug('order closed prematurely; did it auto-fill?')

examples/ws2/orders.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict'
22

3-
const Promise = require('bluebird')
43
const { Order } = require('bfx-api-node-models')
54
const { args: { apiKey, apiSecret }, debug } = require('../util/setup')
65
const WSv2 = require('../../lib/transports/ws2')
@@ -42,7 +41,7 @@ async function execute () {
4241
debug('got submit confirmation for order %d [%d]', o.cid, o.id)
4342

4443
// wait a bit...
45-
await Promise.delay(2 * 1000)
44+
await new Promise(resolve => setTimeout(resolve, 2 * 1000))
4645

4746
if (orderClosed) {
4847
return debug('order closed prematurely; did it auto-fill?')

lib/transports/ws2.js

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
const { EventEmitter } = require('events')
44
const debug = require('debug')('bfx:ws2')
55
const WebSocket = require('ws')
6-
const Promise = require('bluebird')
76
const CbQ = require('cbq')
87
const _Throttle = require('lodash.throttle') // eslint-disable-line
98
const _isArray = require('lodash/isArray')

lib/ws2_manager.js

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ const _isEqual = require('lodash/isEqual')
66
const _isFinite = require('lodash/isFinite')
77
const _includes = require('lodash/includes')
88
const _pick = require('lodash/pick')
9-
const Promise = require('bluebird')
109
const PromiseThrottle = require('promise-throttle')
1110
const WSv2 = require('./transports/ws2')
1211

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
"bfx-api-node-util": "^1.0.10",
6161
"bfx-api-node-ws1": "^1.0.0",
6262
"bignumber.js": "9.0.0",
63-
"bluebird": "3.5.1",
6463
"cbq": "0.0.1",
6564
"debug": "4.1.1",
6665
"lodash": "^4.17.4",

test/lib/transports/ws2-integration.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
'use strict'
33

44
const assert = require('assert')
5-
const Promise = require('bluebird')
65
const WSv2 = require('../../../lib/transports/ws2')
76
const { Order } = require('bfx-api-node-models')
87
const { MockWSv2Server } = require('bfx-api-mock-srv')
@@ -86,14 +85,14 @@ describe('WSv2 integration', () => {
8685

8786
wss.send([0, 'ou', arr])
8887

89-
await Promise.delay(100)
88+
await new Promise(resolve => setTimeout(resolve, 100))
9089

9190
assert.strictEqual(o.price, 256)
9291
arr[16] = 150
9392

9493
wss.send([0, 'oc', arr])
9594

96-
await Promise.delay(100)
95+
await new Promise(resolve => setTimeout(resolve, 100))
9796

9897
assert.strictEqual(o.price, 150)
9998
o.removeListeners()

test/lib/transports/ws2-unit.js

+10-9
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
'use strict'
33

44
const assert = require('assert')
5-
const Promise = require('bluebird')
65
const SocksProxyAgent = require('socks-proxy-agent')
76
const { MockWSv2Server } = require('bfx-api-mock-srv')
87
const _isFunction = require('lodash/isFunction')
@@ -522,7 +521,7 @@ describe('WSv2 unit', () => {
522521
await ws.auth()
523522

524523
return new Promise((resolve) => {
525-
ws.reconnectAfterClose = new Promise(() => resolve())
524+
ws.reconnectAfterClose = Promise.resolve(resolve())
526525
wss.close() // trigger reconnect
527526
})
528527
})
@@ -542,7 +541,9 @@ describe('WSv2 unit', () => {
542541

543542
ws.reconnectAfterClose = () => {
544543
assert((Date.now() - now) >= 70)
545-
return new Promise(() => resolve())
544+
resolve()
545+
546+
return Promise.resolve()
546547
}
547548

548549
wss.close() // trigger reconnect
@@ -561,7 +562,7 @@ describe('WSv2 unit', () => {
561562
ws.reconnect = async () => assert(false)
562563
await ws.close()
563564

564-
await Promise.delay(50)
565+
await new Promise(resolve => setTimeout(resolve, 50))
565566
})
566567
})
567568

@@ -575,12 +576,12 @@ describe('WSv2 unit', () => {
575576

576577
ws.updateAuthArgs({ apiKey: 'wrong', apiSecret: 'wrong' })
577578
ws.reconnect()
578-
await Promise.delay(50)
579+
await new Promise(resolve => setTimeout(resolve, 50))
579580
assert(!ws.isAuthenticated())
580581

581582
ws.updateAuthArgs({ apiKey: API_KEY, apiSecret: API_SECRET })
582583
ws.reconnect()
583-
await Promise.delay(50)
584+
await new Promise(resolve => setTimeout(resolve, 50))
584585
assert(ws.isAuthenticated())
585586
})
586587

@@ -1685,7 +1686,7 @@ describe('WSv2 unit', () => {
16851686
ws._triggerPacketWD = ws._triggerPacketWD.bind(ws)
16861687
ws._onWSMessage('asdf') // send first packet, init wd
16871688

1688-
await Promise.delay(150)
1689+
await new Promise(resolve => setTimeout(resolve, 150))
16891690

16901691
assert(wdTriggered)
16911692
})
@@ -1703,7 +1704,7 @@ describe('WSv2 unit', () => {
17031704
ws._triggerPacketWD = async () => { assert(false) }
17041705
ws._onWSMessage('asdf')
17051706

1706-
await Promise.delay(200)
1707+
await new Promise(resolve => setTimeout(resolve, 200))
17071708

17081709
clearInterval(sendInterval)
17091710
clearTimeout(ws._packetWDTimeout)
@@ -2222,7 +2223,7 @@ describe('WSv2 unit', () => {
22222223
ws = createTestWSv2Instance()
22232224
ws._isAuthenticated = true
22242225
ws.cancelOrder = async () => {
2225-
return Promise.delay(10)
2226+
return new Promise(resolve => setTimeout(resolve, 10))
22262227
}
22272228

22282229
await ws.cancelOrders([1, 2])

test/lib/ws2_manager.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
'use strict'
33

44
const assert = require('assert')
5-
const Promise = require('bluebird')
65
const _isObject = require('lodash/isObject')
76
const _isArray = require('lodash/isArray')
87
const WS2Manager = require('../../lib/ws2_manager')
@@ -59,7 +58,7 @@ describe('WS2Manager', () => {
5958
m._sockets.push({
6059
ws: {
6160
reconnect: async () => {
62-
await Promise.delay(10)
61+
await new Promise(resolve => setTimeout(resolve, 10))
6362
called = true
6463
}
6564
}
@@ -90,7 +89,7 @@ describe('WS2Manager', () => {
9089
m._sockets.push({
9190
ws: {
9291
close: async () => {
93-
await Promise.delay(10)
92+
await new Promise(resolve => setTimeout(resolve, 10))
9493
called = true
9594
}
9695
}

0 commit comments

Comments
 (0)