Merge pull request #578 from vitaliystoliarovcc/fix/emit-public-funding-trades

Fix public funding trades parsing

Author: vigan-abd

CHANGELOG

@@ -1,5 +1,9 @@
+5.0.4
+- fix: public funding trade parsing
+- styling: fix code formatting
+
 5.0.0
-- upgrade: upgraded bfx-api-node-rest to 4.0.0, breaks previous versions compatibility 
+- upgrade: upgraded bfx-api-node-rest to 4.0.0, breaks previous versions compatibility
 - fix: jsdocs
 
 4.0.17

examples/rest2/wallets.js

@@ -72,15 +72,15 @@ async function execute () {
 
       ...(_isFinite(value)
         ? [
-          prepareAmount(value),
-          currency !== valueCCY
-            ? prepareAmount(lastPrices[symbolForWallet({ currency })])
-            : 1
-        ]
+            prepareAmount(value),
+            currency !== valueCCY
+              ? prepareAmount(lastPrices[symbolForWallet({ currency })])
+              : 1
+          ]
         : [
-          '-',
-          '-'
-        ])
+            '-',
+            '-'
+          ])
     ]
   })
 

lib/transports/ws2.js

@@ -473,7 +473,7 @@ class WSv2 extends EventEmitter {
       return authSeq !== this._lastAuthSeq
         ? new Error(
           `invalid auth seq #, expected no advancement but got ${authSeq}`
-        )
+          )
         : null
     }
 
@@ -971,7 +971,7 @@ class WSv2 extends EventEmitter {
     let data = payload
 
     if (this._transform) { // correctly parse single trade/array of trades
-      const M = eventName[0] === 'f' ? FundingTrade : PublicTrade
+      const M = eventName[0] === 'f' && msg[2].length === 8 ? FundingTrade : PublicTrade
       const trades = M.unserialize(data)
 
       if (_isArray(trades) && trades.length === 1) {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bitfinex-api-node",
-  "version": "5.0.3",
+  "version": "5.0.4",
   "description": "Node reference library for Bitfinex API",
   "engines": {
     "node": ">=8.3.0"