-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generator settings not honored by "context menu" and "export vault with password" flows #13208
Comments
Thank you for reporting this issue! We've added this to our internal tracking system. |
Hi there, I am unable to reproduce this issue, it has been escalated for further investigation. If you have more information that can help us, please add it below. Thanks! |
@Greenderella Did you perform both "Test A" and "Test B"? |
To avoid adding just a 'me too', I'll add some context about how I'm experiencing this. I recently installed Brave and started experiencing this issue after installing the extension where my generator settings are set to passphrases, but the shortcut and context menu are generating passwords. I fired up Chrome again and tested and the shortcut and context menu generate passphrases. In either browser, if I try to change to the other in the generator settings, the shortcut and context menu continue to generate based on the prior setting. Both browsers are running the same version of the extension, 2025.1.2 |
It appears the reason this is happening is because the context menu is still using the legacy generator logic. We’re working on migrating all of our systems to use the new generator logic so that we can eliminate the “v1” logic. I’ll be able to address this once I migrate the autofill system. (soon™) |
@audreyality Is this also the explanation for why the keyboard shortcut Ctrl+Shift+9 does not work as expected, or is that a separate issue? |
Steps To Reproduce
Perform both Test A and Test B.
Test A:
Test B:
Expected Result
In both Test A and Test B, the three generated passwords obtained in Steps 4–6 should conform to the settings that had been configured in Steps 2–3.
Actual Result
Either Test A or Test B fails, such that none of the three generated passwords obtained in Steps 4–6 honor the settings that had been configured in Steps 2–3. If Test A works, then Test B will incorrectly generate passwords instead of passphrases; if Test B works, then Test A will incorrectly generate passphrases instead of passwords.
Screenshots or Videos
No response
Additional Context
This behavior is recent, although I do not know the exact version in which it started. My tests used a Chrome browser, but other users have reported the same issue occurring in other browsers, in this Community Forum thread.
Operating System
Windows
Operating System Version
Windows 11 (23H2)
Web Browser
Chrome
Browser Version
No response
Build Version
Version: 2025.1.2; SDK: 'main (28c7e29)'
Issue Tracking Info
The text was updated successfully, but these errors were encountered: