Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator settings not honored by "context menu" and "export vault with password" flows #13208

Open
1 task done
bwbug opened this issue Feb 2, 2025 · 6 comments
Open
1 task done
Labels
browser Browser Extension bug

Comments

@bwbug
Copy link

bwbug commented Feb 2, 2025

Steps To Reproduce

Perform both Test A and Test B.

Test A:
  1. Open Generator view in the browser extension.
  2. Set generation option to "Password".
  3. Modify the settings (e.g., number of characters, character classes, etc.).
  4. In the browser, use the right-click context menu option Bitwarden > Generate password (copied), then paste the clipboard to examine the generated password.
  5. In the browser, use the keyboard shortcut Ctrl+Shift+9, then paste the clipboard to examine the generated password.
  6. In the extension, go to Settings > Vault > Export Vault, select the ".json (Encrypted)" format and the "Password protected" type, click the generate icon 🔄 in the "File password" field, and then examine the generated password by clicking the toggle visibility icon 👁️.
Test B:
  1. Open Generator view in the browser extension.
  2. Set generation option to "Passphrase".
  3. Modify the settings (e.g., number of words, character separator, etc.).
  4. In the browser, use the right-click context menu option Bitwarden > Generate password (copied), then paste the clipboard to examine the generated password.
  5. In the browser, use the keyboard shortcut Ctrl+Shift+9, then paste the clipboard to examine the generated password.
  6. In the extension, go to Settings > Vault > Export Vault, select the ".json (Encrypted)" format and the "Password protected" type, click the generate icon 🔄 in the "File password" field, and then examine the generated password by clicking the toggle visibility icon 👁️.

Expected Result

In both Test A and Test B, the three generated passwords obtained in Steps 4–6 should conform to the settings that had been configured in Steps 2–3.

Actual Result

Either Test A or Test B fails, such that none of the three generated passwords obtained in Steps 4–6 honor the settings that had been configured in Steps 2–3. If Test A works, then Test B will incorrectly generate passwords instead of passphrases; if Test B works, then Test A will incorrectly generate passphrases instead of passwords.

Screenshots or Videos

No response

Additional Context

This behavior is recent, although I do not know the exact version in which it started. My tests used a Chrome browser, but other users have reported the same issue occurring in other browsers, in this Community Forum thread.

Operating System

Windows

Operating System Version

Windows 11 (23H2)

Web Browser

Chrome

Browser Version

No response

Build Version

Version: 2025.1.2; SDK: 'main (28c7e29)'

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@bwbug bwbug added browser Browser Extension bug labels Feb 2, 2025
@bitwarden-bot
Copy link

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-17883

@Greenderella
Copy link
Member

Hi there,

I am unable to reproduce this issue, it has been escalated for further investigation. If you have more information that can help us, please add it below.

Thanks!

@bwbug
Copy link
Author

bwbug commented Feb 4, 2025

@Greenderella Did you perform both "Test A" and "Test B"?

@mattzuba
Copy link

mattzuba commented Feb 6, 2025

To avoid adding just a 'me too', I'll add some context about how I'm experiencing this.

I recently installed Brave and started experiencing this issue after installing the extension where my generator settings are set to passphrases, but the shortcut and context menu are generating passwords. I fired up Chrome again and tested and the shortcut and context menu generate passphrases. In either browser, if I try to change to the other in the generator settings, the shortcut and context menu continue to generate based on the prior setting. Both browsers are running the same version of the extension, 2025.1.2

@audreyality
Copy link
Member

It appears the reason this is happening is because the context menu is still using the legacy generator logic.

We’re working on migrating all of our systems to use the new generator logic so that we can eliminate the “v1” logic. I’ll be able to address this once I migrate the autofill system. (soon™)

@audreyality audreyality changed the title Generator settings not honored outside Generator view Generator settings not honored by context menu and export vault with passport features Feb 11, 2025
@audreyality audreyality changed the title Generator settings not honored by context menu and export vault with passport features Generator settings not honored by "context menu" and "export vault with password" flows Feb 11, 2025
@bwbug
Copy link
Author

bwbug commented Feb 11, 2025

It appears the reason this is happening is because the context menu is still using the legacy generator logic.

@audreyality Is this also the explanation for why the keyboard shortcut Ctrl+Shift+9 does not work as expected, or is that a separate issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

No branches or pull requests

5 participants