fix vet errors

Author: yuin

.travis.yml

@@ -7,9 +7,9 @@ go:
 
 before_install:
   - go get github.com/axw/gocov/gocov
-  - go get github.com/yuin/goveralls
+  - go get github.com/mattn/goveralls
   - if ! go get code.google.com/p/go.tools/cmd/cover; then go get golang.org/x/tools/cmd/cover; fi
 install:
   - go get -u -v $(go list -f '{{join .Imports "\n"}}{{"\n"}}{{join .TestImports "\n"}}' ./... | sort | uniq | grep -v gopher-lua)
 script:
-  - $HOME/gopath/bin/goveralls -service=travis-ci -vetoff
+  - $HOME/gopath/bin/goveralls -service=travis-ci

_state.go

@@ -1054,7 +1054,6 @@ func (ls *LState) Get(idx int) LValue {
 			return LNil
 		}
 	}
-	return LNil
 }
 
 func (ls *LState) Push(value LValue) {

_vm.go

@@ -612,9 +612,9 @@ func init() {
 				cf.Pc = 0
 				cf.Base = RA
 				cf.LocalBase = RA + 1
-				cf.ReturnBase = cf.ReturnBase
+				// cf.ReturnBase = cf.ReturnBase
 				cf.NArgs = nargs
-				cf.NRet = cf.NRet
+				// cf.NRet = cf.NRet
 				cf.TailCall++
 				lbase := cf.LocalBase
 				if meta {
@@ -855,7 +855,6 @@ func numberArith(L *LState, opcode int, lhs, rhs LNumber) LNumber {
 		return LNumber(math.Pow(flhs, frhs))
 	}
 	panic("should not reach here")
-	return LNumber(0)
 }
 
 func objectArith(L *LState, opcode int, lhs, rhs LValue) LValue {

channellib.go

@@ -46,7 +46,11 @@ func channelSelect(L *LState) int {
 	cases := make([]reflect.SelectCase, L.GetTop())
 	top := L.GetTop()
 	for i := 0; i < top; i++ {
-		cas := reflect.SelectCase{reflect.SelectSend, reflect.ValueOf(nil), reflect.ValueOf(nil)}
+		cas := reflect.SelectCase{
+			Dir:  reflect.SelectSend,
+			Chan: reflect.ValueOf(nil),
+			Send: reflect.ValueOf(nil),
+		}
 		tbl := L.CheckTable(i + 1)
 		dir, ok1 := tbl.RawGetInt(1).(LString)
 		if !ok1 {

cmd/glua/glua.go

@@ -36,8 +36,7 @@ Available options are:
   -dc      dump VM codes
   -i       enter interactive mode after executing 'script'
   -p file  write cpu profiles to the file
-  -v       show version information
-`)
+  -v       show version information`)
 	}
 	flag.Parse()
 	if len(opt_p) != 0 {

compile.go

@@ -1048,8 +1048,6 @@ func compileExpr(context *funcContext, reg int, expr ast.Expr, ec *expcontext) i
 		panic(fmt.Sprintf("expr %v not implemented.", reflect.TypeOf(ex).Elem().Name()))
 	}
 
-	panic("should not reach here")
-	return sused
 } // }}}
 
 func compileExprWithPropagation(context *funcContext, expr ast.Expr, reg *int, save *int, propergator func(int, *int, *int, int)) { // {{{
@@ -1108,7 +1106,6 @@ func constFold(exp ast.Expr) ast.Expr { // {{{
 
 		return exp
 	}
-	return exp
 } // }}}
 
 func compileFunctionExpr(context *funcContext, funcexpr *ast.FunctionExpr, ec *expcontext) { // {{{

parse/lexer.go

@@ -49,7 +49,11 @@ type Scanner struct {
 
 func NewScanner(reader io.Reader, source string) *Scanner {
 	return &Scanner{
-		Pos:    ast.Position{source, 1, 0},
+		Pos: ast.Position{
+			Source: source,
+			Line:   1,
+			Column: 0,
+		},
 		reader: bufio.NewReaderSize(reader, 4096),
 	}
 }

pm/pm.go

@@ -600,7 +600,6 @@ redo:
 		goto redo
 	}
 	panic("should not reach here")
-	return false, sp, m
 }
 
 /* }}} */

script_test.go

@@ -54,7 +54,8 @@ func testScriptCompile(t *testing.T, script string) {
 		t.Fatal(err3)
 		return
 	}
-	proto.String()
+	nop := func(s string) {}
+	nop(proto.String())
 }
 
 func testScriptDir(t *testing.T, tests []string, directory string) {

state.go

@@ -1139,7 +1139,6 @@ func (ls *LState) Get(idx int) LValue {
 			return LNil
 		}
 	}
-	return LNil
 }
 
 func (ls *LState) Push(value LValue) {