Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package canvg dependency. #7

Open
ddscentral opened this issue Jun 25, 2024 · 0 comments
Open

Package canvg dependency. #7

ddscentral opened this issue Jun 25, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ddscentral
Copy link

I probably am a little bit old-school but I'd rather have the complete distributable in a single place instead of relying on external sources.

You have a line in index.html

import { Canvg } from 'https://cdn.skypack.dev/canvg@^4.0.0'

Since you already have qrcode lib included in the repo, it would be a good idea to also include the canvg lib. This way, the application would be completely self-contained.
canvg can be downloaded from npm and packed easily using esbuild or any other bundler tool of your choice.

@bizzycola bizzycola self-assigned this Aug 12, 2024
@bizzycola bizzycola added the enhancement New feature or request label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants