Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the first problem still relevant with the new JSON parser? #35

Open
arthsmn opened this issue Dec 24, 2024 · 2 comments
Open

Is the first problem still relevant with the new JSON parser? #35

arthsmn opened this issue Dec 24, 2024 · 2 comments

Comments

@arthsmn
Copy link

arthsmn commented Dec 24, 2024

After Emacs 30 introduced a new JSON parser I was wondering if the first problem is still relevant, and how faster the parsing might be.

@Ergus
Copy link

Ergus commented Jan 15, 2025

The new parser is actually very fast and it does not rely in external libraries. So, a new benchmark set could be interesting now in Emacs 30.

BTW: I don't totally understand the current benchmarks numbers I see in the Actions. Some of them seems actually confusing. How can I see the speedup difference with and without booster?

@jdtsmith
Copy link
Contributor

The benchmarks provided are for the artificial case of reading from JSON vs. reading from the equivalent (translated) bytecode. That's related to but not identical to the actual speedup you might get.

You can actually run the booster without doing JSON conversion; see --disable-bytecode. If you use eglot-booster it has the option --eglot-booster-io-only to enable this. If you do so maybe report your findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants