From a109c4ef23468b1b2e7eead7ec141364c768272e Mon Sep 17 00:00:00 2001 From: Newt6611 <45097780+Newt6611@users.noreply.github.com> Date: Fri, 15 Nov 2024 01:46:58 +0800 Subject: [PATCH] refactor: check logger is nil or not when creating connection manager (#232) --- connmanager/connection_manager.go | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/connmanager/connection_manager.go b/connmanager/connection_manager.go index 2f9726a..f102195 100644 --- a/connmanager/connection_manager.go +++ b/connmanager/connection_manager.go @@ -16,6 +16,7 @@ package connmanager import ( "fmt" + "io" "log/slog" "sync" @@ -81,6 +82,9 @@ type ConnectionManagerHost struct { } func NewConnectionManager(cfg ConnectionManagerConfig) *ConnectionManager { + if cfg.Logger == nil { + cfg.Logger = slog.New(slog.NewJSONHandler(io.Discard, nil)) + } return &ConnectionManager{ config: cfg, connections: make( @@ -103,15 +107,15 @@ func (c *ConnectionManager) AddHost( Port: port, Tags: tmpTags, } - if c.config.Logger != nil { - c.config.Logger.Debug( - fmt.Sprintf( - "connmanager: adding host: %+v", - cmHost, - ), - "component", "connmanager", - ) - } + + c.config.Logger.Debug( + fmt.Sprintf( + "connmanager: adding host: %+v", + cmHost, + ), + "component", "connmanager", + ) + c.hosts = append( c.hosts, cmHost,