Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockheight expiry strategy is accidentally conservative #120

Open
steveluscher opened this issue Nov 10, 2022 · 0 comments
Open

Blockheight expiry strategy is accidentally conservative #120

steveluscher opened this issue Nov 10, 2022 · 0 comments

Comments

@steveluscher
Copy link

const timeoutBlockHeight = signedAtBlock
? signedAtBlock.lastValidBlockHeight +
MAXIMUM_NUMBER_OF_BLOCKS_FOR_TRANSACTION
: 0;

Hey! I stumbled upon this line of code. I don't think this does what it's meant to do. lastValidBlockHeight is actually ‘the block height at which this recent blockhash will no longer be valid,’ so timeoutBlockHeight is just signedAtBlock.lastValidBlockHeight here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant