Skip to content

Commit 529af2a

Browse files
committed
Skip coverage html generation in Alpine
There a bug either in the genhtml utility in Alpine or in coverage.py that trips over some categories that are in the dump file. We don't use these files in CI for anything so for now we should skip the html generation. Signed-off-by: Pablo Galindo <[email protected]>
1 parent 603f4e1 commit 529af2a

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

.github/workflows/build.yml

+3
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@ jobs:
7272
container:
7373
image: alpine
7474
options: --cap-add=SYS_PTRACE
75+
env:
76+
# Coverage is kind of broken in Alpine
77+
SKIP_COVERAGE_HTML: 1
7578
steps:
7679
- uses: actions/checkout@v4
7780
- name: Set up dependencies

Makefile

+4-2
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,10 @@ pycoverage: ## Run the test suite, with Python code coverage
7777
--cov-fail-under=90 \
7878
--cov-append $(PYTEST_ARGS) \
7979
tests
80-
$(PYTHON) -m coverage lcov -i -o pycoverage.lcov
81-
genhtml *coverage.lcov --branch-coverage --output-directory memray-coverage $(GENHTMLOPTS)
80+
if [ -z "$$SKIP_COVERAGE_HTML" ]; then \
81+
$(PYTHON) -m coverage lcov -i -o pycoverage.lcov
82+
genhtml *coverage.lcov --branch-coverage --output-directory memray-coverage $(GENHTMLOPTS); \
83+
fi
8284

8385
.PHONY: valgrind
8486
valgrind: ## Run valgrind, with the correct configuration

news/693.bugfix.rst

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixed a bug that was causing tracking of runtime libraries that are part of the linker cache not work in macOS 15.

0 commit comments

Comments
 (0)