support ARRAY[] in INSERT values argument

Author: RandomEtc

index.js

@@ -124,13 +124,9 @@ function INSERT(table) {
 
 INSERT.prototype = {
     VALUES: function(object) {
-        var values = this.values,
-            columns = Object.keys(object),
-            placeholders = columns.map(function(c,i) {
-                values.push(object[c]);
-                return '$' + values.length;
-            });
-        this.text += '('+columns.join(', ')+') VALUES(' + placeholders.join(', ') + ')';
+        var columns = Object.keys(object),
+            insert_values = get_insert_values(object, columns, this.values);
+        this.text += '('+columns.join(', ')+') VALUES(' + insert_values + ')';
         return this;
     },
     RETURNING: function(returning) {
@@ -169,10 +165,18 @@ DELETE.prototype = {
     }
 };
 
-function get_set_placeholder(value, values) {
+function get_insert_values(object, columns, values) {
+    return columns.map(function(c,i) {
+        return get_placeholder(object[c], values);
+    }).join(', ');
+}
+
+
+// used in get_set_clause and get_insert_values...
+function get_placeholder(value, values) {
     if (Array.isArray(value)) {
         return 'ARRAY[' + value.map(function(item){
-            return get_set_placeholder(item, values);
+            return get_placeholder(item, values);
         }).join(', ') + ']'
     } else {
         values.push(value);
@@ -183,7 +187,7 @@ function get_set_placeholder(value, values) {
 // only used in UPDATE, but here for clarity/efficiency
 function get_set_clause(set, values) {
     return Object.keys(set).map(function(c,i){
-        return c + ' = ' + get_set_placeholder(set[c], values);
+        return c + ' = ' + get_placeholder(set[c], values);
     }).join(', ');
 }
 

test/insert.js

@@ -58,4 +58,14 @@ describe('INSERT', function(){
       sql.values.should.eql([null,null,null]);
     });
   });
+  describe('#(table).VALUES(set_with_arrays)', function(){
+    it('should return an object with array placeholders and flattened values', function(){
+      var sql = INSERT('foo').VALUES({ a: [ 1, 2 ], b: [ [ 3, 4 ], [ 5, 6 ] ], c: [ 7, 8 ] });
+      sql.should.have.text;
+      sql.should.have.values;
+      sql.text.should.equal('INSERT INTO foo(a, b, c) VALUES(ARRAY[$1, $2], ARRAY[ARRAY[$3, $4], ARRAY[$5, $6]], ARRAY[$7, $8])');
+      sql.values.should.be.an.instanceOf(Array)
+      sql.values.should.eql([1,2,3,4,5,6,7,8]);
+    });
+  });
 });