Fix Sonarqube warnings

Author: satran004

core/src/main/java/com/bloxbean/cardano/client/account/Account.java

@@ -184,7 +184,7 @@ public Account(Network network, byte[] accountKey, int account, int index) {
         if (accountKey.length == 96)
             this.accountKey = accountKey;
         else
-            throw new RuntimeException("Invalid length (Account Private Key): " + accountKey.length);
+            throw new AccountException("Invalid length (Account Private Key): " + accountKey.length);
 
         this.derivationPath = DerivationPath.createExternalAddressDerivationPathForAccount(account);
         this.derivationPath.getIndex().setValue(index);
@@ -207,13 +207,13 @@ private Account(Network network, String mnemonic, byte[] rootKey, byte[] account
             if (rootKey.length == 96)
                 this.rootKey = rootKey;
             else
-                throw new RuntimeException("Invalid length (Root Pvt Key): " + rootKey.length);
+                throw new AccountException("Invalid length (Root Pvt Key): " + rootKey.length);
         } else if (accountKey != null && accountKey.length > 0) {
             this.mnemonic = null;
             if (accountKey.length == 96)
                 this.accountKey = accountKey;
             else
-                throw new RuntimeException("Invalid length (Account Private Key): " + accountKey.length);
+                throw new AccountException("Invalid length (Account Private Key): " + accountKey.length);
         }
 
         baseAddress();
@@ -706,7 +706,7 @@ private HdKeyPair getHdKeyPairFromDerivationPath(DerivationPath derivationPath)
         } else if (rootKey != null && rootKey.length > 0) {
             hdKeyPair = new CIP1852().getKeyPairFromRootKey(this.rootKey, derivationPath);
         } else {
-            throw new RuntimeException("HDKeyPair derivation failed. Only one of mnemonic, rootKey, or accountKey should be set.");
+            throw new AccountException("HDKeyPair derivation failed. Only one of mnemonic, rootKey, or accountKey should be set.");
         }
 
         return hdKeyPair;

core/src/main/java/com/bloxbean/cardano/client/account/AccountException.java

@@ -0,0 +1,18 @@
+package com.bloxbean.cardano.client.account;
+
+public class AccountException extends RuntimeException {
+    public AccountException() {
+    }
+
+    public AccountException(String msg) {
+        super(msg);
+    }
+
+    public AccountException(Throwable cause) {
+        super(cause);
+    }
+
+    public AccountException(String msg, Throwable cause) {
+        super(msg, cause);
+    }
+}

core/src/test/java/com/bloxbean/cardano/client/account/AccountTest.java

@@ -614,8 +614,9 @@ void testAccountFromMnemonic_15words_acc4_index3() {
 
     @Test
     void testAccountFromRootKey_15words_acc4_index3() {
+
         //Original mnemonic
-        //String mnemonic = "top exact spice seed cloud birth orient bracket happy cat section girl such outside elder";
+        //top exact spice seed cloud birth orient bracket happy cat section girl such outside elder
 
         String rootKey = "root_xsk1zza6z52v8gelnaqdhuny3ywlccud5dtm8rvvyem4utnfwzcaa9pspsmdm99qfpy2qz7sw9sts59mrkegmdqyjen5ykm4z3ccyrkn8g5mm0qw35arvwxclfh6tj3s4x7t2q85wenvppjpxckcxgnf8vd80ug0l6rw";
 
@@ -632,7 +633,7 @@ void testAccountFromRootKey_15words_acc4_index3() {
     @Test
     void testAccountFromAccountKey_15words_acc4_index3() {
         //Original mnemonic
-        //String mnemonic = "top exact spice seed cloud birth orient bracket happy cat section girl such outside elder";
+        //top exact spice seed cloud birth orient bracket happy cat section girl such outside elder
 
         String accountKey = "acct_xsk1azc6gn5zkdprp4gkapmhdckykphjl62rm9224699ut5z6xcaa9p4hv5hmjfgcrzk72tnsqh6dw0njekdjpsv8nv5h5hk6lpd4ag62zenwhzqs205kfurd7kgs8fm5gx4l4j8htutwj060kyp5y5kgw55qc8lsltd";
 

hd-wallet/src/main/java/com/bloxbean/cardano/hdwallet/Wallet.java

@@ -321,7 +321,7 @@ public Optional<HdKeyPair> getRootKeyPair() {
 
     public Optional<byte[]> getRootPvtKey() {
         return getRootKeyPair()
-                .map(rootKeyPair -> rootKeyPair.getPrivateKey().getBytes());
+                .map(rkp -> rkp.getPrivateKey().getBytes());
     }
 
     /**

hd-wallet/src/test/java/com/bloxbean/cardano/hdwallet/WalletTest.java

@@ -188,7 +188,7 @@ void testAccountWhenFromRootKey_account_2() {
     @Test
     void testAccountWhenFromAccountKey_15words_acc4_index3() {
         //Original mnemonic
-        //String mnemonic = "top exact spice seed cloud birth orient bracket happy cat section girl such outside elder";
+        //top exact spice seed cloud birth orient bracket happy cat section girl such outside elder
 
         String accountKey = "acct_xsk1azc6gn5zkdprp4gkapmhdckykphjl62rm9224699ut5z6xcaa9p4hv5hmjfgcrzk72tnsqh6dw0njekdjpsv8nv5h5hk6lpd4ag62zenwhzqs205kfurd7kgs8fm5gx4l4j8htutwj060kyp5y5kgw55qc8lsltd";
 
@@ -207,8 +207,10 @@ void testAccountFromAccountKey_128bytes_throwsException() {
         //Added random 32 bytes at the end to test with a 128 bytes key
         String accountKey = "e8b1a44e82b34230d516e87776e2c4b06f2fe943d954aae8a5e2e82d1b1de9435bb297dc928c0c56f2973802fa6b9f3966cd9060c3cd94bd2f6d7c2daf51a50b3375c40829f4b27836fac881d3ba20d5fd647baf8b749fa7d881a129643a9406c333ef7429361bdb1414e15e054f6654bce419d26057d0e38d76993f9c3ab71f";
 
+        var network = Networks.testnet();
+        var acctKeyBytes = HexUtil.decodeHexString(accountKey);
         assertThrows(WalletException.class, () -> {
-            Wallet.createFromAccountKey(Networks.testnet(), HexUtil.decodeHexString(accountKey));
+            Wallet.createFromAccountKey(network, acctKeyBytes);
         });
     }
 
@@ -218,8 +220,9 @@ void testAccountFromRootKey_128Bytes_throwsException() {
         String rootKey128Bytes = "48c0062f7d36bb4f8194beb2762d4e323fd84dd947e7d09db8f8b454b74a105560631379e7b976f41e165133978ecd56fe65114f5ba6aaafaa0d482a48e71edec6377bc291444b063f64d59b955447c9fb3a3026e43f9052d82a792d304fd644c333ef7429361bdb1414e15e054f6654bce419d26057d0e38d76993f9c3ab71f";
         byte[] rootKey = HexUtil.decodeHexString(rootKey128Bytes);
 
+        var network = Networks.testnet();
         assertThrows(WalletException.class, () -> {
-            Wallet.createFromRootKey(Networks.testnet(), rootKey);
+            Wallet.createFromRootKey(network, rootKey);
         });
     }
 }