Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OgmiosEpochService getProtocolParams does not return some params #424

Closed
nemo83 opened this issue Sep 4, 2024 · 4 comments
Closed

OgmiosEpochService getProtocolParams does not return some params #424

nemo83 opened this issue Sep 4, 2024 · 4 comments
Assignees
Milestone

Comments

@nemo83
Copy link
Contributor

nemo83 commented Sep 4, 2024

Not sure if it's an issue,

But

        var ogmiosProtoParams = ogmiosEpochService.getProtocolParameters().getValue();```

Does not return all params, eg

`minFeeRefScriptCostPerByte=null`

This causes tx balancing to fail.
@satran004
Copy link
Member

Thanks @nemo83. This is a bug. The minFeeRefScriptCostPerByte is currently missing in the Ogmios backend service implementation, as well as in Koios.

So, the reference script fee will only work with the Blockfrost backend in version 0.6.0-beta1.

Workaround for now:
You can manually set minFeeRefScriptCostPerByte=15 after retrieving the protocol parameters from the backend provider.

We will fix this in the next release.

@satran004 satran004 added this to the 0.6.0-beta2 milestone Sep 5, 2024
@nemo83
Copy link
Contributor Author

nemo83 commented Sep 5, 2024

Thanks for confirming this. Let me know if you need any help in getting this done. I just wanted to be sure it was an actual issue (and not me mis-using the library)

@satran004
Copy link
Member

I will fix this as part of the following PR as there is also a dependency with cost model

#418

@satran004 satran004 self-assigned this Sep 5, 2024
@nemo83
Copy link
Contributor Author

nemo83 commented Sep 5, 2024

I will fix this as part of the following PR as there is also a dependency with cost model

#418

oh interesting, I thought there were issues w/ costs models too, but could not pin point to it. happy to hear you're on top of things! and thanks for fixing ogmios too.

@nemo83 nemo83 closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants