From 8613ccb6b2ed7da2c2fcaf502ceb897578398c1f Mon Sep 17 00:00:00 2001 From: Koen Hufkens Date: Mon, 22 May 2023 14:22:12 +0200 Subject: [PATCH] cran comment, shorter --- cran-comments.md | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 4faa96c..92ca779 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -22,14 +22,9 @@ a breakdown of coverage statistics I refer to: https://app.codecov.io/gh/bluegreen-labs/appeears -Limited functions are documented with "dynamic" examples which are run. -The code required to trap potential errors if the service is down -exceeds that of actual function coverage (which can be confusing, and the -reason I tend to avoid this). However, I will retain these changes -as per review request. Functions covered in this way are, rs_layers() and -rs_products() which require no authentication. rs_build_task() is now exposed -as well (not wrapped in dontrun). All other function touch upon some form of -authentication (and can't be tested due to credentials). +Limited functions are documented with "dynamic" examples which are run (on CRAN). +Functions covered in this way are, rs_layers() and rs_products() which require no authentication. rs_build_task() is now exposed as well (not wrapped in dontrun). +All other function touch upon some form of authentication (and can't be tested due to credentials). Furthermore, I added Elio Campitelli as contributor, as the R6 refactoring of {ecmwfr} was mostly his work. I've borrowed this for the package in hindsight