Skip to content

Commit fffe54a

Browse files
committed
Add vendorOptions to NewVendorConfigManager for use in config/dell.go specifically
1 parent 878882b commit fffe54a

File tree

4 files changed

+11
-9
lines changed

4 files changed

+11
-9
lines changed

config/asrockrack.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ type asrockrackBiosCfgSetting struct {
3434
Type string `xml:"type,attr"`
3535
}
3636

37-
func NewAsrockrackVendorConfigManager(configFormat string) (VendorConfigManager, error) {
37+
func NewAsrockrackVendorConfigManager(configFormat string, vendorOptions map[string]string) (VendorConfigManager, error) {
3838
asrr := &asrockrackVendorConfig{}
3939

4040
switch strings.ToLower(configFormat) {

config/dell.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ type dellComponentAttribute struct {
3939
Value string `xml:",chardata" json:"Value"`
4040
}
4141

42-
func NewDellVendorConfigManager(configFormat string) (VendorConfigManager, error) {
42+
func NewDellVendorConfigManager(configFormat string, vendorOptions map[string]string) (VendorConfigManager, error) {
4343
dell := &dellVendorConfig{}
4444

4545
switch strings.ToLower(configFormat) {
@@ -53,13 +53,15 @@ func NewDellVendorConfigManager(configFormat string) (VendorConfigManager, error
5353
SystemConfiguration: &dellSystemConfiguration{},
5454
}
5555

56+
dell.setSystemConfiguration(vendorOptions["model"], vendorOptions["servicetag"])
5657
return dell, nil
5758
}
5859

59-
func (cm *dellVendorConfig) SetSystemConfiguration(model, servicetag, timestamp string) {
60+
func (cm *dellVendorConfig) setSystemConfiguration(model, servicetag string) {
6061
cm.ConfigData.SystemConfiguration.Model = model
6162
cm.ConfigData.SystemConfiguration.ServiceTag = servicetag
62-
cm.ConfigData.SystemConfiguration.TimeStamp = timestamp
63+
// TODO(jwb) Make this 'now'
64+
cm.ConfigData.SystemConfiguration.TimeStamp = "Tue Nov 2 21:19:16 2021"
6365
}
6466

6567
// FindComponent locates an existing DellComponent if one exists in the ConfigData, if not

config/interface.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@ type VendorConfigManager interface {
1414
Marshal() (string, error)
1515
}
1616

17-
func NewVendorConfigManager(configFormat, vendorName string) (VendorConfigManager, error) {
17+
func NewVendorConfigManager(configFormat, vendorName string, vendorOptions map[string]string) (VendorConfigManager, error) {
1818
switch strings.ToLower(vendorName) {
1919
case common.VendorDell:
20-
return NewDellVendorConfigManager(configFormat)
20+
return NewDellVendorConfigManager(configFormat, vendorOptions)
2121
case common.VendorSupermicro:
22-
return NewSupermicroVendorConfigManager(configFormat)
22+
return NewSupermicroVendorConfigManager(configFormat, vendorOptions)
2323
case common.VendorAsrockrack:
24-
return NewAsrockrackVendorConfigManager(configFormat)
24+
return NewAsrockrackVendorConfigManager(configFormat, vendorOptions)
2525
default:
2626
return nil, UnknownVendorError(strings.ToLower(vendorName))
2727
}

config/supermicro.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ type supermicroBiosCfgSetting struct {
3434
Type string `xml:"type,attr"`
3535
}
3636

37-
func NewSupermicroVendorConfigManager(configFormat string) (VendorConfigManager, error) {
37+
func NewSupermicroVendorConfigManager(configFormat string, vendorOptions map[string]string) (VendorConfigManager, error) {
3838
supermicro := &supermicroVendorConfig{}
3939

4040
switch strings.ToLower(configFormat) {

0 commit comments

Comments
 (0)