Skip to content

Commit 09d77d6

Browse files
committed
chore: Upgrade html5lib to version 1.1. (tensorflow#5490)
As noted by tensorflow#5478 , tensorboard fails when run in a python 3.10 environment. The reporter fortunately discovered that the problems would be fixed with an upgrade of our html5lib dependency. I tested by building a python3.10 virtualenv on my machine (this required building python 3.10 from source as we don't have it natively). I also ran the tensorboard with some logdirs and did some basic sanity. I specifically checked that markdown rendering seemed to be working for a couple text plugin logs that I have.
1 parent 90651ff commit 09d77d6

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

third_party/html5lib.BUILD

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ py_library(
1616
"html5lib/_tokenizer.py",
1717
"html5lib/_trie/__init__.py",
1818
"html5lib/_trie/_base.py",
19-
"html5lib/_trie/datrie.py",
2019
"html5lib/_trie/py.py",
2120
"html5lib/_utils.py",
2221
"html5lib/constants.py",

third_party/python.bzl

+4-4
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,11 @@ def tensorboard_python_workspace():
4747
http_archive(
4848
name = "org_html5lib",
4949
urls = [
50-
"http://mirror.tensorflow.org/github.com/html5lib/html5lib-python/archive/1.0.1.tar.gz",
51-
"https://github.com/html5lib/html5lib-python/archive/1.0.1.tar.gz",
50+
"http://mirror.tensorflow.org/github.com/html5lib/html5lib-python/archive/1.1.tar.gz",
51+
"https://github.com/html5lib/html5lib-python/archive/1.1.tar.gz",
5252
],
53-
sha256 = "fabbebd6a55d07842087f13849076eeed350aa8bb6c9ec840f6a6aba9388db06",
54-
strip_prefix = "html5lib-python-1.0.1",
53+
sha256 = "66e9e24a53c10c27abb6be8a3cf2cf55824c6ea1cef8570a633cb223ec46e894",
54+
strip_prefix = "html5lib-python-1.1",
5555
build_file = str(Label("//third_party:html5lib.BUILD")),
5656
)
5757

0 commit comments

Comments
 (0)