Merge branch 'develop'

Author: bmino

config/config.json.example

@@ -30,7 +30,6 @@
 
     "LOG": {
         "LEVEL": "debug",
-        "VERBOSE": true,
         "PRETTY_PRINT": true
     },
 
@@ -40,6 +39,10 @@
         "INITIALIZATION_INTERVAL": 75
     },
 
-    "CALCULATION_COOLDOWN": 250
+    "TIMING": {
+        "RECEIVE_WINDOW": 5000,
+        "USE_SERVER_TIME": false,
+        "CALCULATION_COOLDOWN": 250
+    }
 
 }

config/readme.md

@@ -121,10 +121,6 @@ Upon each version update you should copy the new syntax from `config.json.exampl
     * `"trace"`
     * `"silent"`
 
-### `LOG.VERBOSE` (Boolean)
-* Default: `true`
-* Description: Enables more detailed log messages from the Binance api wrapper
-
 #### `LOG.PRETTY_PRINT` (Boolean)
 * Default: `true`
 * Description: Format the logs with pino-pretty. Read the logs via a terminal for best results
@@ -159,6 +155,16 @@ Upon each version update you should copy the new syntax from `config.json.exampl
 ---
 
 
-#### `CALCULATION_COOLDOWN` (Number)
+### `TIMING`
+
+#### `TIMING.RECEIVE_WINDOW` (Number)
+* Default: `5000`
+* Description: Time (ms) after a given timestamp until a request is no longer considered valid
+
+#### `TIMING.USE_SERVER_TIME` (Boolean)
+* Default: `false`
+* Description: Synchronize with the Binance API server time and modify request timestamps
+
+#### `TIMING.CALCULATION_COOLDOWN` (Number)
 * Default: `250`
 * Description: Delay (ms) between completing calculations and starting another cycle

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "binance-triangle-arbitrage",
-  "version": "5.4.0",
+  "version": "5.5.0",
   "repository": {
     "type": "git",
     "url": "https://github.com/bmino/binance-triangle-arbitrage.git"

package.json

@@ -1,11 +1,14 @@
 const CONFIG = require('../../config/config');
 const logger = require('./Loggers');
-const binance = require('node-binance-api')({
+const Binance = require('node-binance-api');
+const binance = new Binance().options({
     APIKEY: CONFIG.KEYS.API,
     APISECRET: CONFIG.KEYS.SECRET,
     test: !CONFIG.TRADING.ENABLED,
-    log: (msg) => logger.binance.info(msg),
-    verbose: CONFIG.LOG.VERBOSE,
+    log: (...args) => logger.binance.info(args.length > 1 ? args : args[0]),
+    verbose: true,
+    recvWindow: CONFIG.TIMING.RECEIVE_WINDOW,
+    useServerTime: CONFIG.TIMING.USE_SERVER_TIME,
 });
 
 const BinanceApi = {

src/main/BinanceApi.js

@@ -59,7 +59,7 @@ function calculateArbitrage() {
 
     if (CONFIG.HUD.ENABLED) refreshHUD(results);
     displayCalculationResults(successCount, errorCount, calculationTime);
-    setTimeout(calculateArbitrage, CONFIG.CALCULATION_COOLDOWN);
+    setTimeout(calculateArbitrage, CONFIG.TIMING.CALCULATION_COOLDOWN);
 }
 
 function displayCalculationResults(successCount, errorCount, calculationTime) {
@@ -153,6 +153,21 @@ function checkConfig() {
         logger.execution.error(msg);
         throw new Error(msg);
     }
+    if (CONFIG.TIMING.RECEIVE_WINDOW > 60000) {
+        const msg = `Receive window (${CONFIG.TIMING.RECEIVE_WINDOW}) must be less than 60000`;
+        logger.execution.error(msg);
+        throw new Error(msg);
+    }
+    if (CONFIG.TIMING.RECEIVE_WINDOW <= 0) {
+        const msg = `Receive window (${CONFIG.TIMING.RECEIVE_WINDOW}) must be a positive value`;
+        logger.execution.error(msg);
+        throw new Error(msg);
+    }
+    if (CONFIG.TIMING.CALCULATION_COOLDOWN <= 0) {
+        const msg = `Calculation cooldown (${CONFIG.TIMING.CALCULATION_COOLDOWN}) must be a positive value`;
+        logger.execution.error(msg);
+        throw new Error(msg);
+    }
 }
 
 function checkBalances() {