fix ut issue

fix the ut issue by avoid pollute the pst.cache when append journal
bnb-chain · Jan 9, 2025 · 7db8b0b · 7db8b0b
1 parent e109b4e
commit 7db8b0b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/core/state/pevm_statedb.go b/core/state/pevm_statedb.go
@@ -169,25 +169,27 @@ func (pst *UncommittedDB) Prepare(rules params.Rules, sender, coinbase common.Ad
 //  2. object
 
 func (pst *UncommittedDB) SubBalance(addr common.Address, amount *uint256.Int) {
-	obj := pst.getOrNewObject(addr)
 	if amount.IsZero() {
+		obj := pst.getOrNewObject(addr)
 		if !obj.empty(pst) {
 			return
 		}
 	}
 	pst.journal.append(newJBalance(pst.cache[addr], addr))
+	obj := pst.getOrNewObject(addr)
 	newb := new(uint256.Int).Sub(obj.balance, amount)
 	pst.cache.setBalance(addr, newb)
 }
 
 func (pst *UncommittedDB) AddBalance(addr common.Address, amount *uint256.Int) {
-	obj := pst.getOrNewObject(addr)
 	if amount.IsZero() {
+		obj := pst.getOrNewObject(addr)
 		if !obj.empty(pst) {
 			return
 		}
 	}
 	pst.journal.append(newJBalance(pst.cache[addr], addr))
+	obj := pst.getOrNewObject(addr)
 	newb := new(uint256.Int).Add(obj.balance, amount)
 	pst.cache.setBalance(addr, newb)
 }