Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: txpool concurrent map issue #252

Merged
merged 2 commits into from
Jan 13, 2025
Merged

fix: txpool concurrent map issue #252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fa2024
fix concurrent map read/write issue
Jan 11, 2025
c2a2dff
improve performance of txpool.stats()
Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions core/txpool/legacypool/legacypool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,15 +609,7 @@ func (pool *LegacyPool) Stats() (int, int) {
// stats retrieves the current pool stats, namely the number of pending and the
// number of queued (non-executable) transactions.
func (pool *LegacyPool) stats() (int, int) {
pending := 0
for _, list := range pool.pending {
pending += list.Len()
}
queued := 0
for _, list := range pool.queue {
queued += list.Len()
}
return pending, queued
return pool.pendingCounter, pool.queueCounter
}

// Content retrieves the data content of the transaction pool, returning all the
Expand Down Expand Up @@ -1496,7 +1488,7 @@ func (pool *LegacyPool) runReorg(done chan struct{}, reset *txpoolResetRequest,
resetPromoteTimer.Update(promoteDur)
resetFeedTimer.Update(sendfeedDur)

pending, queued := pool.stats()
pending, queued := pool.Stats()
if reset.newHead != nil && reset.oldHead != nil {
log.Info("Transaction pool reorged", "from", reset.oldHead.Number.Uint64(), "to", reset.newHead.Number.Uint64(),
"reorgCost", reorgCost, "waittime", waittime, "promoted", len(promoted), "demoted", demoted, "sendFeed", sendFeed, "pending", pending, "queued", queued,
Expand Down
Loading