Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make docker image build and push job work #264

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

will-2012
Copy link
Contributor

@will-2012 will-2012 commented Feb 18, 2025

Description

Fix the DockerImage build and push ci action, which interrupts the automatic image generated & uploaded workflow.

The previous failed scene

https://github.com/bnb-chain/op-geth/actions/runs/13053301943/job/37322899096

#29 [linux/arm64 builder 8/8] RUN cd /go-ethereum && go run build/ci.go install -static ./cmd/geth
#29 167.3 # net
#29 167.3 gcc: internal compiler error: Segmentation fault signal terminated program cc1
#29 167.3 Please submit a full bug report, with preprocessed source (by using -freport-bug).
#29 167.3 See <https://gitlab.alpinelinux.org/alpine/aports/-/issues> for instructions.
#29 ERROR: process "/dev/.buildkit_qemu_emulator /bin/sh -c cd /go-ethereum && go run build/ci.go install -static ./cmd/geth" did not complete successfully: exit code: 1
------
 > [linux/arm64 builder 8/8] RUN cd /go-ethereum && go run build/ci.go install -static ./cmd/geth:
167.3 # net
167.3 gcc: internal compiler error: Segmentation fault signal terminated program cc1
167.3 Please submit a full bug report, with preprocessed source (by using -freport-bug).
167.3 See <https://gitlab.alpinelinux.org/alpine/aports/-/issues> for instructions.

The current fixed-pr succeed scene

https://github.com/bnb-chain/op-geth/actions/runs/13387923709/job/37388777820

Rationale

This failure was introduced by the PR #260; it introduced cgo dependencies, and qemu(default version)+ubuntu-latest(24.04.1)+arm64 will trigger the problem.

There are two ways to workaround this problem:

  1. Update ubuntu-latest(24.04.1) -> ubuntu-22.04

Or

  1. Specify a newer qemu version

Currently we chose 2

Example

N/A.

Changes

Notable changes:

  • github workflow config.

@github-actions github-actions bot requested review from krish-nr and redhdx February 18, 2025 09:59
@will-2012 will-2012 changed the title fix: add specified qemu version fix: fix docker image build and push action Feb 18, 2025
@will-2012 will-2012 changed the title fix: fix docker image build and push action fix: make docker image build and push job work Feb 18, 2025
@will-2012 will-2012 added the R4R Ready for review label Feb 18, 2025
Copy link
Contributor

@sysvm sysvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeylichang joeylichang merged commit 1534953 into develop Feb 19, 2025
3 checks passed
@joeylichang joeylichang deleted the fix-ci-failed branch February 19, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R4R Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants