fix: remove custom & add spinner tests

Signed-off-by: Alexander Mangel <[email protected]>

Author: Cygnusfear

packages/prompts/src/spinner.ts

@@ -11,7 +11,7 @@ import {
 } from './common.js';
 
 export interface SpinnerOptions extends CommonOptions {
-	indicator?: 'dots' | 'timer' | "custom";
+	indicator?: 'dots' | 'timer';
 	onCancel?: () => void;
 	cancelMessage?: string;
 	errorMessage?: string;
@@ -32,10 +32,9 @@ export const spinner = ({
 	output = process.stdout,
 	cancelMessage,
 	errorMessage,
-	...props
+	frames = unicode ? ['◒', '◐', '◓', '◑'] : ['•', 'o', 'O', '0'],
+	delay = unicode ? 80 : 120,
 }: SpinnerOptions = {}): SpinnerResult => {
-	const frames = props.frames ? props.frames : unicode ?  ['◒', '◐', '◓', '◑'] : ['•', 'o', 'O', '0'];
-	const delay = props.delay ? props.delay : unicode ? 80 : 120;
 	const isCI = process.env.CI === 'true';
 
 	let unblock: () => void;

packages/prompts/test/__snapshots__/spinner.test.ts.snap

@@ -1,5 +1,32 @@
 // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
 
+exports[`spinner (isCI = false) > indicator customization > custom delay 1`] = `
+[
+  "[?25l",
+  "│
+",
+  "◒  ",
+  "",
+  "",
+  "◐  ",
+  "",
+  "",
+  "◓  ",
+  "",
+  "",
+  "◑  ",
+]
+`;
+
+exports[`spinner (isCI = false) > indicator customization > custom frames 1`] = `
+[
+  "[?25l",
+  "│
+",
+  "🐴  ",
+]
+`;
+
 exports[`spinner (isCI = false) > message > sets message for next frame 1`] = `
 [
   "<cursor.hide>",
@@ -195,6 +222,24 @@ exports[`spinner (isCI = false) > stop > renders submit symbol and stops spinner
 ]
 `;
 
+exports[`spinner (isCI = true) > indicator customization > custom delay 1`] = `
+[
+  "[?25l",
+  "│
+",
+  "◒  ...",
+]
+`;
+
+exports[`spinner (isCI = true) > indicator customization > custom frames 1`] = `
+[
+  "[?25l",
+  "│
+",
+  "🐴  ...",
+]
+`;
+
 exports[`spinner (isCI = true) > message > sets message for next frame 1`] = `
 [
   "<cursor.hide>",

packages/prompts/test/spinner.test.ts

@@ -149,6 +149,31 @@ describe.each(['true', 'false'])('spinner (isCI = %s)', (isCI) => {
 		});
 	});
 
+	describe('indicator customization', () => {
+		test('custom frames', () => {
+			const result = prompts.spinner({ output, frames: ['🐴', '🦋', '🐙', '🐶'] });
+
+			result.start();
+
+			vi.advanceTimersByTime(80);
+
+			expect(output.buffer).toMatchSnapshot();
+		});
+
+		test('custom delay', () => {
+			const result = prompts.spinner({ output, delay: 200 });
+
+			result.start();
+
+			// there are 4 frames
+			for (let i = 0; i < 4; i++) {
+				vi.advanceTimersByTime(200);
+			}
+
+			expect(output.buffer).toMatchSnapshot();
+		});
+	});
+
 	describe('process exit handling', () => {
 		let processEmitter: EventEmitter;