Skip to content

Commit 4452b3b

Browse files
authored
Merge pull request #114 from boostcampwm-2024/refactor/#108
Refactor/#108 docker 파일 최적화, test 분리
2 parents b2478f4 + 43c4f1f commit 4452b3b

27 files changed

+415
-207
lines changed

core/package.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,7 @@
2525
},
2626
"devDependencies": {
2727
"tsup": "^8.0.0",
28-
"@playwright/test": "^1.49.0",
29-
"@types/pngjs": "^6.0.5",
30-
"pngjs": "^7.0.0",
31-
"typescript": "^5.0.0",
32-
"vitest": "^2.1.5"
28+
"vitest": "^2.1.5",
29+
"typescript": "^5.0.0"
3330
}
3431
}

docker-build/dev/Dockerfile.server

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,8 @@ COPY pnpm-workspace.yaml package.json pnpm-lock.yaml tsconfig.base.json ./
1313
COPY core ./core
1414
COPY server ./server
1515

16-
RUN pnpm install --filter core --frozen-lockfile
17-
RUN pnpm install --filter server --frozen-lockfile
18-
19-
RUN pnpm --filter @troublepainter/core build
20-
RUN pnpm --filter server build
16+
RUN pnpm install --filter core --frozen-lockfile && pnpm --filter @troublepainter/core build
17+
RUN pnpm install --filter server --frozen-lockfile && pnpm --filter server build
2118

2219
FROM node:22-slim AS production
2320
WORKDIR /app
@@ -33,8 +30,7 @@ COPY --from=builder /app/server/dist ./server/dist
3330
COPY --from=builder /app/core/package.json ./core/package.json
3431
COPY --from=builder /app/core/dist ./core/dist
3532

36-
RUN corepack enable && corepack prepare [email protected] --activate
37-
RUN pnpm install --prod --filter '!@troublepainter/core'
33+
RUN corepack enable && corepack prepare [email protected] --activate && pnpm install --prod --no-optional --filter '!@troublepainter/core'
3834

3935
WORKDIR /app/server
4036

docker-build/prod/Dockerfile.server

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,8 @@ COPY pnpm-workspace.yaml package.json pnpm-lock.yaml tsconfig.base.json ./
1313
COPY core ./core
1414
COPY server ./server
1515

16-
RUN pnpm install --filter core --frozen-lockfile
17-
RUN pnpm install --filter server --frozen-lockfile
18-
19-
RUN pnpm --filter @troublepainter/core build
20-
RUN pnpm --filter server build
16+
RUN pnpm install --filter core --frozen-lockfile && pnpm --filter @troublepainter/core build
17+
RUN pnpm install --filter server --frozen-lockfile && pnpm --filter server build
2118

2219
FROM node:22-slim AS production
2320
WORKDIR /app
@@ -33,8 +30,7 @@ COPY --from=builder /app/server/dist ./server/dist
3330
COPY --from=builder /app/core/package.json ./core/package.json
3431
COPY --from=builder /app/core/dist ./core/dist
3532

36-
RUN corepack enable && corepack prepare [email protected] --activate
37-
RUN pnpm install --prod --filter '!@troublepainter/core'
33+
RUN corepack enable && corepack prepare [email protected] --activate && pnpm install --prod --no-optional --filter '!@troublepainter/core'
3834

3935
WORKDIR /app/server
4036

e2e-test/.prettierrc

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
{
2+
"printWidth": 120,
3+
"tabWidth": 2,
4+
"useTabs": false,
5+
"semi": true,
6+
"singleQuote": true,
7+
"quoteProps": "as-needed",
8+
"trailingComma": "all",
9+
"bracketSpacing": true,
10+
"arrowParens": "always",
11+
"proseWrap": "preserve",
12+
"endOfLine": "auto",
13+
"embeddedLanguageFormatting": "auto"
14+
}
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

core/crdt/test/drawing-performance.spec.ts renamed to e2e-test/crdt/test/drawing-performance.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { test as base, Page, chromium, BrowserContext } from '@playwright/test';
1+
import { BrowserContext, chromium, Page, test as base } from '@playwright/test';
22
import { drawEventData } from './drawing-utils';
33
import eventData1 from './drawing-performance/event-data-1.json' assert { type: 'json' };
44
import eventData2 from './drawing-performance/event-data-2.json' assert { type: 'json' };

0 commit comments

Comments
 (0)