bite 8 bugfix

Author: boraxpr

8/rotate.py

@@ -6,25 +6,28 @@ def rotate(string, n):
     if n == 0:
         return string
     elif n>0:
+        if n > len(string):
+            return string
         for i in range(n):
-            print("i " + i.__str__())
-            toAdd = toAdd.__add__(string[0])
-            print("Toadd " + toAdd)
-            string = string.replace(string[0], "", 1)
-            print("str " + string)
+            # print("i " + i.__str__())
+            toAdd = toAdd + string[0]
+            # print("Toadd " + toAdd)
+            string = string[1 : :]
+            # print("str " + string)
             # print(string)
         string = string+toAdd
         return string
     elif n<0:
-        for i in range(abs(n)):
-            print("i " + i.__str__())
-            toAdd = string[len(string)-1]+toAdd
-            print("Toadd " + toAdd)
-            string = string.replace(string[len(string)-1], "",1)
-            print("str " + string)
+        for i in range(n, 0 , 1):
+            # print("i " + i.__str__())
+            toAdd = string[len(string)-1] + toAdd
+            # print("Toadd " + toAdd)
+            string = string[: -1 :]
+            # print("str " + string)
+        # print(toAdd)
         string = toAdd+string
         return string
 
-# print(rotate("hello",-2))
+# print(rotate("hello", -2))
 # print("zxc".__len__())
 # print("zxc"[2])

8/test_rotate.py

@@ -34,4 +34,9 @@ def test_rotation_of_n_bigger_than_string():
     # which is 100 % 15 (len string) => n=10
     mod = 100 % len(string)  # 10
     assert rotate(string, mod) in (expected_solution1,
-                                   expected_solution2)
+                                   expected_solution2)
+
+# print(rotate('pybites loves julian and bob!',-15))
+test_bigger_rotation_of_positive_n()
+test_bigger_rotation_of_negative_n()
+test_rotation_of_n_bigger_than_string()