Fix warning: ‘beta’ may be used uninitialized in this function

jlblancoc · jlblancoc · commit 0114cc883258 · 2024-10-29T08:05:27.000+01:00
diff --git a/gtsam/nonlinear/NonlinearConjugateGradientOptimizer.h b/gtsam/nonlinear/NonlinearConjugateGradientOptimizer.h
@@ -247,6 +247,9 @@ std::tuple<V, int> nonlinearConjugateGradient(
         case DirectionMethod::DaiYuan:
           beta = DaiYuan(currentGradient, prevGradient, direction);
           break;
+        default:
+          throw runtime_error(
+              "NonlinearConjugateGradientOptimizer: Invalid directionMethod");
       }
 
       direction = currentGradient + (beta * direction);

Original file line number	Diff line number	Diff line change
`@@ -247,6 +247,9 @@ std::tuple<V, int> nonlinearConjugateGradient(`
`247`	`247`	`case DirectionMethod::DaiYuan:`
`248`	`248`	`beta = DaiYuan(currentGradient, prevGradient, direction);`
`249`	`249`	`break;`
	`250`	`+ default:`
	`251`	`+ throw runtime_error(`
	`252`	`+ "NonlinearConjugateGradientOptimizer: Invalid directionMethod");`
`250`	`253`	`}`
`251`	`254`
`252`	`255`	`direction = currentGradient + (beta * direction);`