Skip to content

Commit 8bd4738

Browse files
committed
Fix warning: ‘beta’ may be used uninitialized in this function
1 parent d48b1fc commit 8bd4738

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

gtsam/nonlinear/NonlinearConjugateGradientOptimizer.h

+5
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
#include <gtsam/base/Manifold.h>
2222
#include <gtsam/nonlinear/NonlinearOptimizer.h>
2323

24+
#include <stdexcept>
25+
2426
namespace gtsam {
2527

2628
/// Fletcher-Reeves formula for computing β, the direction of steepest descent.
@@ -247,6 +249,9 @@ std::tuple<V, int> nonlinearConjugateGradient(
247249
case DirectionMethod::DaiYuan:
248250
beta = DaiYuan(currentGradient, prevGradient, direction);
249251
break;
252+
default:
253+
throw std::runtime_error(
254+
"NonlinearConjugateGradientOptimizer: Invalid directionMethod");
250255
}
251256

252257
direction = currentGradient + (beta * direction);

0 commit comments

Comments
 (0)