-
Notifications
You must be signed in to change notification settings - Fork 0
Static image assests should be removed from repo except in cases where no IIIF service is available #27
Comments
It took me a while to find URL where is this image shown...if you don't mind, please include the URL of where the image is seen on the site. Now that I did find it, I see it's an Ala question, as it's a content image that's edited here: If there are other locations this is happening, we'd need URLs to try to help find the source to change. |
I'll go through and fix these |
Done |
Before this is closed, @diedrick can you please remove all superfluous static assets from the GitHub repo so they are no longer tracked in the commit tree |
I removed the images I could, but we don't have a systematic way to do this, and there's a lot more places we should add iiif images in the data. So for example, in the Admin People section:: Then we'll have a better way to track what's actually being still used or not. When those are complete, tell me so I can start digging into it. And we should make this a v2 thing since it'll be some work and this is a pretty minor change. |
I'll start changing the header and thumbnail images (where appropriate) and let you know when it's done |
Just popping in to say the images are now loading very slow, so I'm going to re-do the image URLs with ones that are not gigantic as I realized that's what I did the first time around |
I've updated all the images in the people articles. For the headers/thumbnails/other assets with a set image size, I'm having problems doing that with the IIIF cropping tool; I can select a max width or height for the crop but not a specific hxw ratio. I'm not sure if this will be a problem with the current set up — if I, for example, set the proper width, will the system be able to crop it to the proper height or will things get weird? |
I've put in a sample IIIF link for a thumbnail image here: https://argo.stage.diedrick.com/admin/people.php/1 |
Worth noting that I'm also kind of picky about what is included in the final crop, so if there are alternate methods for having greater control over the cropping area and ensuring the correct height and width ratio (something similar to the cropping tool in eg photoshop would be ideal) I would love to know about it @garrettdashnelson |
I'd use this handy online tool: But with the code it creates, you should also specify an output width so it's not oversized on the website. Just replace the word 'full' with '500,' so this: |
BTW, here's what that record looks like on the live site: |
Static image content should not be duplicated in the repo if it could be served directly from IIIF server.
For instance, the file
https://github.com/bplmaps/argomaps/blob/master/static/content/blaskowitz-1.jpg
should be removed from repo and references to it should replaced with:https://iiif.digitalcommonwealth.org/iiif/2/commonwealth:z603vw05v/5787,1105,5748,7233/,1200/0/default.jpg
For handy cropping/resizing of IIIF images from endpoint, see https://geoservices.leventhalmap.org/iiif-tools/
The text was updated successfully, but these errors were encountered: