chore: update package dependencies (fixes #184) (#186)

* chore: udpate package dependencies
* Add typescript-eslint-parser as a direct dependency of the plugin

Author: weirdpattern

.gitignore

@@ -14,3 +14,5 @@ versions.json
 /packages/**/node_modules
 .sublimelinterrc
 yarn.lock
+/.vscode/*
+!/.vscode/settings.json

README.md

@@ -26,14 +26,12 @@ $ npm install eslint-plugin-typescript --save-dev
 
 ## Usage
 
-Add `typescript-eslint-parser` to the `parser` field and `typescript` to the plugins section of your `.eslintrc` configuration file. You can omit the `eslint-plugin-` prefix:
+Add `eslint-plugin-typescript/parser` to the `parser` field and `typescript` to the plugins section of your `.eslintrc` configuration file. You can omit the `eslint-plugin-` prefix:
 
 ```json
 {
-    "parser": "typescript-eslint-parser",
-    "plugins": [
-        "typescript"
-    ]
+    "parser": "eslint-plugin-typescript/parser",
+    "plugins": ["typescript"]
 }
 ```
 
@@ -47,6 +45,9 @@ Then configure the rules you want to use under the rules section.
 }
 ```
 
+Note: The plugin provides its own version of the `typescript-eslint-parser` via `eslint-plugin-typescript/parser`.
+This guarantees 100% compatibility between the plugin and the parser.
+
 ## Supported Rules
 
 <!-- Please run `npm run docs` to update this section -->

lib/rules/class-name-casing.js

@@ -45,7 +45,7 @@ module.exports = {
          * @returns {undefined}
          */
         function report(decl, id) {
-            id = id || decl.id;
+            const resolvedId = id || decl.id;
 
             let friendlyName;
 
@@ -62,8 +62,10 @@ module.exports = {
             }
 
             context.report({
-                node: id,
-                message: `${friendlyName} '${id.name}' must be PascalCased`,
+                node: resolvedId,
+                message: `${friendlyName} '${
+                    resolvedId.name
+                }' must be PascalCased`,
             });
         }
 

lib/rules/member-delimiter-style.js

@@ -156,7 +156,9 @@ module.exports = {
                         if (missingDelimiter) {
                             // add the missing delimiter
                             return fixer.insertTextAfter(lastToken, token);
-                        } else if (isLast && !opts.requireLast) {
+                        }
+
+                        if (isLast && !opts.requireLast) {
                             return fixer.remove(lastToken);
                         }
 

lib/rules/no-type-alias.js

@@ -196,10 +196,10 @@ module.exports = {
             }
 
             return compositionType === "TSUnionType"
-                ? `${type[0].toUpperCase()}${type.substring(
+                ? `${type[0].toUpperCase()}${type.slice(
                       1
                   )} in union types are not allowed`
-                : `${type[0].toUpperCase()}${type.substring(
+                : `${type[0].toUpperCase()}${type.slice(
                       1
                   )} in intersection types are not allowed`;
         }

package.json

@@ -25,21 +25,24 @@
         "precommit": "npm test && lint-staged"
     },
     "dependencies": {
-        "requireindex": "~1.1.0"
+        "requireindex": "~1.2.0",
+        "typescript-eslint-parser": "^17.0.1"
     },
     "devDependencies": {
-        "eslint": "^4.13.1",
-        "eslint-config-eslint": "^4.0.0",
-        "eslint-config-prettier": "^2.9.0",
+        "eslint": "^5.9.0",
+        "eslint-config-eslint": "^5.0.1",
+        "eslint-config-prettier": "^3.3.0",
         "eslint-docs": "^0.1.1",
         "eslint-plugin-node": "^6.0.1",
-        "eslint-plugin-prettier": "^2.2.0",
-        "husky": "^0.14.3",
-        "lint-staged": "^6.0.0",
-        "mocha": "^4.0.1",
+        "eslint-plugin-prettier": "^3.0.0",
+        "husky": "^1.2.0",
+        "lint-staged": "^8.1.0",
+        "mocha": "^5.2.0",
         "prettier-eslint-cli": "^4.7.1",
-        "typescript": "~2.9",
-        "typescript-eslint-parser": "^17.0.1"
+        "typescript": "~2.9"
+    },
+    "peerDependencies": {
+        "eslint": ">=4.13.1 < 6"
     },
     "lint-staged": {
         "*.js": [

parser.js

@@ -0,0 +1,10 @@
+/**
+ * @fileoverview Internal parser
+ * @author Patricio Trevino
+ */
+
+"use strict";
+
+// export the typescript-eslint-parser.
+// this forces the parser to be a direct dependency of the plugin.
+module.exports = require("typescript-eslint-parser");