Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shortcuts]: Prototype UI for configuring shortcuts #28657

Closed
fallaciousreasoning opened this issue Feb 21, 2023 · 0 comments · Fixed by brave/brave-core#17296
Closed

[Shortcuts]: Prototype UI for configuring shortcuts #28657

fallaciousreasoning opened this issue Feb 21, 2023 · 0 comments · Fixed by brave/brave-core#17296

Comments

@fallaciousreasoning
Copy link

fallaciousreasoning commented Feb 21, 2023

We should add a prototype behind the brave://flags#brave-commands flag for customizing shortcuts. In the prototype, it should be possible to:

  1. Add shortcuts (to commands with existing shortcuts, or to other Chromium commands, such as pin & duplicate tab).
  2. Remove existing shortcuts (if you don't like Ctrl+P to print, should can remove it).
  3. Reset shortcuts to whatever they are by default

This is a follow up to #28329 and a prerequisite to #354

@fallaciousreasoning fallaciousreasoning added OS/Android Fixes related to Android browser functionality OS/Desktop and removed OS/Android Fixes related to Android browser functionality labels Feb 21, 2023
@fallaciousreasoning fallaciousreasoning changed the title [Prototype]: Make it possible to configure shortcuts [Shortcuts]: Prototype UI for configuring shortcuts Feb 21, 2023
@fallaciousreasoning fallaciousreasoning self-assigned this Feb 21, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants