Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make data structure to manage split view data #37088

Closed
Tracked by #36986
sangwoo108 opened this issue Mar 26, 2024 · 0 comments · Fixed by brave/brave-core#22772
Closed
Tracked by #36986

Make data structure to manage split view data #37088

sangwoo108 opened this issue Mar 26, 2024 · 0 comments · Fixed by brave/brave-core#22772
Assignees
@sangwoo108
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.66.x - Release

Comments

@sangwoo108
Copy link

sangwoo108 commented Mar 26, 2024 •
edited
Loading

Sub task of #36986

  • SplitViewBrowserData

    • This object's lifecycle will be bound to Browser object
    • Manages which tabs are tiled together

  • SplitViewTabStripModelAdapter

    • This object observes tab strip model and synchronize tiled tabs state. e.g. index, pinned state, and etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

Introduce basic data structure for Split view feature brave/brave-core
2 participants
@sangwoo108 @brave-builds