Brave crashes with Split View flag enabled when getting a popup window.

[ghost]

Description

@sangwoo108

I know Split View is still early WIP, but I don't see tracked in #36986 how the browser insta-crashes when you get a popup window or Devtools is used as a separated window just by having the flag enabled, regardless if Split View is being used or not.

Steps to Reproduce

1. Enable brave://flags/#brave-split-view
2. go to https://www.rrc.texas.gov/resource-center/research/gis-viewer/gis-popup-blocker-test/ and run the test
3. it should immediately crash

Brave version (brave://version info)

1.66.71 Chromium: 124.0.6367.29 (Official Build) nightly (64-bit)
Windows 11 Version 23H2 (Build 22631.3296)

[sangwoo108]

Hi, @TEMP-ad ! Thanks for trying the new feature. Hopefully, this could have been fixed by https://github.com/brave/brave-core/pull/22975/files . Could you try later again? Thanks heaps as always!

[ghost]

@sangwoo108 based on the commits that PR was merged for 1.66.70 and I was still getting crashes with .71 today. I still installed and tested 1.66.72 as soon as it was available few minutes ago and I am still getting the same crashes.
I tested it with a total new user data us usual and it was reproduced just the same, but I never got any crash besides this one.

Well, not really, I also got a crash when I tried to move the split view to another window but I had a feeling it would crash when doing that, so apparently I have to break into tabs and move them and then re-split view the tabs again. But that's while using split view, while this crash is the one that I get just by having the split view enabled not in use, and then I always forget and click in the same link with left click instead of pressing the ctrl so it opens as a tab.

But I can't wait to see how you polish and develop Split view! amazing work as usual.

[sangwoo108]

Thanks for checking! Will look into it.

[ghost]

Thanks for the quick fix!
I have been using the feature since minute 1, so it is nice not to get crashes anymore, I was holding any feedback about Split View for later when it is more obvious feedback might be needed.

Most of the little quirks I get are usually when when switching tabs anyway.

• Like you can see a big re-drawing/re-layout of elements when switching from non-split tabs to split view tabs and viceversa, especially if the tab(s) have tons of CSS and JS.

  Recording.2024-04-14.125347.mp4
  Recording.2024-04-14.131446.mp4

• Also, you get some blank tab behavior, if you have twitch video in a split and you are on the other split and then you click on the volume button of the twitch video, it will stay a blank screen until you release the button.

  Recording.2024-04-14.130947.mp4

• YT videos only get a tiny little flicker when you do that, so it is less noticeable.

  You can also get a flicker easily by switching between the (active) tabs being split views through the tab strip or clicking on their contents, seems like the heavier the page with JS and CSS the more noticeable.

  Recording.2024-04-14.124810.mp4

• Some UI buttons get activated/highlighted for the right split tab. If you have sidebar on, it will be the first button of the sidebar, if you don't show the sidebar, it will be the Search tabs button. Easy to replicate, you only need to click first on the content of the right split, then the content of the left split and then you click on the second/right split on the tab strip.

  Recording.2024-04-14.130019.mp4

• And then Fullscreen of videos are not being fullscreen but like it fullscreen in the split, not the worst behavior but if you try to click on the tab's content of the non-fullscreen split, it kicks you out of fullscreen.

  Recording.2024-04-14.130817.mp4

So these are the tiny little quirks I have seen, might be Win11 specific, and you might not hear from me regardless split view ever again, because the crash was the most problematic so 👍Hope you have a good day and thanks for your amazing work.

[sangwoo108]

Thanks for the very detailed feedback. Flickering is expected to some extent, as I was trying to not to modify Chromium's logic. But that doesn't mean that I won't try, I'll definately try to find a way to alleviate it. And other things are new to me. I really appreciate your help!