Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded sites cannot be restored #3850

Closed
GeetaSarvadnya opened this issue Mar 22, 2019 · 5 comments
Closed

Excluded sites cannot be restored #3850

GeetaSarvadnya opened this issue Mar 22, 2019 · 5 comments

Comments

@GeetaSarvadnya
Copy link

Description

Excluded sites cannot be restored

Steps to Reproduce

  1. Clean profile 0.64.8
  2. Add a site to A-C table
  3. Exclude site from a-c table by clicking on Delete icon
  4. Click on ...1(Restore All) link
  5. The excluded site is not restored

Actual result:

Excluded sites cannot be restored

Expected result:

Excluded sites should be restored

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.64.8 Chromium: 73.0.3683.75 (Official Build) nightly (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

Reproducible on current release: No

  • Does it reproduce on brave-browser dev/beta builds? No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@brave/legacy_qa

@jasonrsadler
Copy link

+1 repro:

Brave 0.64.15 Chromium: 74.0.3729.22 (Developer Build) (64-bit)
Revision d183f516540c1a0c21310ced2e2170a534bca5a5-refs/branch-heads/3729@{#254}
OS Mac OS X

@NejcZdovc
Copy link
Contributor

@GeetaSarvadnya so you still see restore all link? or what is the problem exactly. If I click on trashcan and then click restore all, link is removed and table is cleared. If I re-visit that publisher is added back to the table.

@NejcZdovc NejcZdovc added needs-more-info The report requires more detail before we can decide what to do with this issue. and removed bug labels Mar 25, 2019
@kjozwiak
Copy link
Member

@NejcZdovc did the behaviour change in 0.64.x regarding restoring publishers back into the a-c table? When you restore under 0.63.20 Chromium: 73.0.3683.75, the website is added back into the table. However under 0.64.8 Chromium: 73.0.3683.75, clicking on Restore All doesn't add anything back into the a-c which might confuse users. Assuming this is what @GeetaSarvadnya is pointing out. CCing @LaurenWags.

Example of 0.63.20 Chromium: 73.0.3683.75:

devExample

Example of 0.64.8 Chromium: 73.0.3683.75:

nightlyExample

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 27, 2019

@kjozwiak yes we changed this, so that it behaves the same as it behaved in Muon. Done here #3459

@NejcZdovc
Copy link
Contributor

closing as this is expected

@NejcZdovc NejcZdovc added closed/not-actionable and removed QA/Test-Plan-Specified QA/Yes needs-more-info The report requires more detail before we can decide what to do with this issue. labels Mar 28, 2019
@NejcZdovc NejcZdovc modified the milestones: 0.64.x - Nightly, Dupe / Invalid / Not actionable Mar 28, 2019
@kjozwiak kjozwiak removed this from the Dupe / Invalid / Not actionable milestone Mar 28, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants